replace globals by locals #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joernu76
reviewed
May 30, 2023
mslib/utils/thermolib.py
Outdated
| @@ -35,7 +35,7 @@ | |||
| from metpy.xarray import preprocess_and_wrap | |||
| import metpy.calc as mpcalc | |||
|
|
|||
| exporter = Exporter(globals()) | |||
| exporter = Exporter(locals()) | |||
There was a problem hiding this comment.
This doesn't make sense. The Exporter is a metpy helper class that maintains the "__all__" list of module symbols.
Also, is there a difference in globals/locals at this point in the code???
I do not now why we use this anyway. I suggest removing it and its decorator use below.
ReimarBauer
commented
May 31, 2023
There was a problem hiding this comment.
@joernu76 can you try to approve this, as initial author I can't
joernu76
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.