Revamp of mscolab operation menu and addition of "archive" operation #1782
Conversation
joernu76
changed the title
| @@ -59,6 +59,8 @@ | |||
| migrate = Migrate(APP, db, render_as_batch=True) | |||
| auth = HTTPBasicAuth() | |||
|
|
|||
| ARCHIVE_THRESHOLD = 30 | |||
There was a problem hiding this comment.
we should maybe make this configurable.
There was a problem hiding this comment.
Maybe. 30 days seems a tad short for me as a typical campaign may run longer.
New issue?
There was a problem hiding this comment.
yes, this needs also a documentation
| db.session.commit() | ||
| # Reload Operation List | ||
| if not temp_operation_active: | ||
| if temp_operation_active != operation.active: |
There was a problem hiding this comment.
the wording maybe can be changed to archived, unarchived etc.
There was a problem hiding this comment.
changing operation.active requires changes to the DB, I guess?
There was a problem hiding this comment.
yes, in the models.
and on staging you could do this by
https://mss.readthedocs.io/en/stable/mscolab.html#data-base-migration
There was a problem hiding this comment.
review and also add new parts to the section Operation based features in
https://github.com/Open-MSS/MSS/blob/develop/docs/mscolab.rst#operation-based-features
There was a problem hiding this comment.
I am not convinced that we should change the DB format to be more consistent in a part that is not user-visible.
There was a problem hiding this comment.
We can do this when we need another change. It is not needed now, but at the moment we introduce something new we anyways have to do a server database migration.
joernu76
force-pushed
the
i1753
branch
3 times, most recently
from
db7a0f9 to
46acf06
Compare
joernu76
changed the title
| self.listOperationsMSC.setToolTip(_translate("MSUIMainWindow", "List of mscolab operations.\n" | ||
| "Double click a operation to activate and view its description.")) | ||
| self.activeOperationDesc.setText(_translate("MSUIMainWindow", "Select Operation to View Description")) | ||
| self.activeOperationsLabel.setText(_translate("MSUIMainWindow", "Operations")) | ||
| self.pbOpenOperationArchive.setText(_translate("MSUIMainWindow", "Operation Archive")) |
There was a problem hiding this comment.
plural?
on the upper list it is also plural and a : is missing on upper one.
There was a problem hiding this comment.
singular in front of "archive" seems to be slightly more common than plural according to google
| else: | ||
| self.ui.activeOperationDesc.setText( | ||
| "Description is too long to show here, for long descriptions go " | ||
| "to operations menu.") | ||
|
|
||
| def update_description_handler(self): | ||
| def change_category_handler(self): | ||
| # only after login |
There was a problem hiding this comment.
just seen that the comment is on two places in the source
the verification "after login" is done on the server.
verify_user_token is a debugging feature which is skipped by default user configuration. When it is not skipped it forces each request to be checked with the server alive and this slows down any event and helps to debug some problems.
There was a problem hiding this comment.
No idea, I copy pasted that comment in changing category over from the changing of description. I am still not 100% sure about how that authentification and verification works.
There was a problem hiding this comment.
I'ver overseen that there, the server has to do all that verification.
| @@ -59,6 +59,8 @@ | |||
| migrate = Migrate(APP, db, render_as_batch=True) | |||
| auth = HTTPBasicAuth() | |||
|
|
|||
| ARCHIVE_THRESHOLD = 30 | |||
There was a problem hiding this comment.
yes, this needs also a documentation
| db.session.commit() | ||
| # Reload Operation List | ||
| if not temp_operation_active: | ||
| if temp_operation_active != operation.active: |
There was a problem hiding this comment.
yes, in the models.
and on staging you could do this by
https://mss.readthedocs.io/en/stable/mscolab.html#data-base-migration
| db.session.commit() | ||
| # Reload Operation List | ||
| if not temp_operation_active: | ||
| if temp_operation_active != operation.active: |
There was a problem hiding this comment.
review and also add new parts to the section Operation based features in
https://github.com/Open-MSS/MSS/blob/develop/docs/mscolab.rst#operation-based-features
This works, when the mscolab server has been updated. I just hot-patched the mss-stage server for testing and it works. |
|
When a category is changed, other users have the old entry in theire opened "Manage Users" - "Clone operation" list selection. We maybe should update this too. |
My Manage User window does not get closed. The behaviour should be the same as with a changed description. With all the category filtering etc. there may be a trigger missing that changes the visible operations. I think that is fine, currently, as this feature will be used seldomly but offers the option to correct for e.g. typo and will sort itself out eventually. Should be fixed eventually, obviously. |
|
On archive we should not allow further changes, by someone else having the operation open
I think in this case we should close the views on other users or go to the local flightpath |
No description provided.