Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: some unit tests failed when using Pandas 2.0 #177

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

JohanKJSchreurs
Copy link
Contributor

Fixes issue #176.

Some fixes to make the code compatible with pandas 2.0.

Tests now pass with both pandas v1.5 and v2.0.

For now, I have not yet pinned the pandas version, because we might want to discuss first if we want to leave it unpinned, or what version constraint we should apply. (I suppose we would either pin it to pandas>=2.0 or to pandas<=2.0 )

I don't know if we have users who may be stuck on pandas 1.5.

@JohanKJSchreurs JohanKJSchreurs linked an issue Apr 11, 2023 that may be closed by this pull request
@soxofaan soxofaan merged commit 80a2800 into master Apr 11, 2023
@soxofaan soxofaan deleted the issue176-fix-pandas-2.0-compatibility branch April 11, 2023 12:18
@soxofaan
Copy link
Member

As long as there is no concrete need to add a constraint at the level of openeo-python-driver library, I would leave things as-is.
If we need constraints for the Terrascope/creodias deploys, we can do that in their respective requirements.txt files (e.g. in openeo-deploy project)

soxofaan added a commit that referenced this pull request Apr 11, 2023
Use reasonably liberal constraint for now (pandas 1.3.5 works on my machine).

Related to #177
@soxofaan
Copy link
Member

I've set the pandas constraint to >=1.3.0 for now (1.3.5 works on my machine), to at least have some constraint.

pandas 2 is relatively young at the moment, so maybe better wait it out a bit before deciding to jump ship completely to >=2.0

soxofaan added a commit that referenced this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix pandas 2.0 compatibility
2 participants