-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue404 automatically validate process graph before download or execute #481
Closed
JohanKJSchreurs
wants to merge
21
commits into
master
from
issue404_automatically-validate-process-graph-before-download-or-execute
Closed
Issue404 automatically validate process graph before download or execute #481
JohanKJSchreurs
wants to merge
21
commits into
master
from
issue404_automatically-validate-process-graph-before-download-or-execute
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now execute / download request will always validate process graph unless user asks to skip validation.
soxofaan
reviewed
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some quick notes already
- collection level option will be more practical and user friendly - per `execute` overriding is still possible - generalize `_warn_if_process_graph_invalid` to `_preflight_validation` (to future proof it) - additional finetuning
- Use `dummy_backend` fixture for more compact setup - Separate TestExecuteFromJsonResources and TestExecuteWithValidation
- use `dummy_backend` for more compact setup - cover more combinations of server-side support, `auto_validate` and explicit `validate` - leverage fixture parameterization more to avoid custom fixtures
…cube100 streamlining
…st_datacube100 streamlining
soxofaan
added a commit
that referenced
this pull request
Oct 18, 2023
- connection level option will be more practical and user friendly - per `execute` overriding is still possible - generalize `_warn_if_process_graph_invalid` to `_preflight_validation` (to future proof it) - additional finetuning
soxofaan
added a commit
that referenced
this pull request
Oct 18, 2023
soxofaan
added a commit
that referenced
this pull request
Oct 18, 2023
merged in 78e8e93 thanks! |
soxofaan
deleted the
issue404_automatically-validate-process-graph-before-download-or-execute
branch
October 18, 2023 13:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #404