Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue404 automatically validate process graph before download or execute #481

Conversation

JohanKJSchreurs
Copy link
Contributor

Implements #404

@JohanKJSchreurs JohanKJSchreurs marked this pull request as ready for review October 4, 2023 09:06
Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some quick notes already

openeo/rest/connection.py Outdated Show resolved Hide resolved
openeo/rest/connection.py Outdated Show resolved Hide resolved
openeo/rest/connection.py Outdated Show resolved Hide resolved
openeo/rest/connection.py Outdated Show resolved Hide resolved
- collection level option will be more practical and user friendly
- per `execute` overriding is still possible
- generalize `_warn_if_process_graph_invalid` to `_preflight_validation` (to future proof it)
- additional finetuning
- Use `dummy_backend` fixture for more compact setup
- Separate TestExecuteFromJsonResources and TestExecuteWithValidation
- use `dummy_backend` for more compact setup
- cover more combinations of server-side support, `auto_validate` and explicit `validate`
- leverage fixture parameterization more to avoid custom fixtures
soxofaan added a commit that referenced this pull request Oct 18, 2023
- connection level option will be more practical and user friendly
- per `execute` overriding is still possible
- generalize `_warn_if_process_graph_invalid` to `_preflight_validation` (to future proof it)
- additional finetuning
soxofaan added a commit that referenced this pull request Oct 18, 2023
- Use `dummy_backend` fixture for more compact setup
- Separate TestExecuteFromJsonResources and TestExecuteWithValidation
soxofaan added a commit that referenced this pull request Oct 18, 2023
- use `dummy_backend` for more compact setup
- cover more combinations of server-side support, `auto_validate` and explicit `validate`
- leverage fixture parameterization more to avoid custom fixtures
@soxofaan
Copy link
Member

merged in 78e8e93

thanks!

@soxofaan soxofaan closed this Oct 18, 2023
@soxofaan soxofaan deleted the issue404_automatically-validate-process-graph-before-download-or-execute branch October 18, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants