Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move xgb import to occur at runtime #135

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

LukeWeidenwalker
Copy link
Contributor

@LukeWeidenwalker LukeWeidenwalker commented Jul 14, 2023

This should speed up the import of this library a bit if xgboost isn't used!

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #135 (d677123) into main (cff6768) will decrease coverage by 0.05%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
- Coverage   75.72%   75.68%   -0.05%     
==========================================
  Files          26       26              
  Lines        1170     1172       +2     
==========================================
+ Hits          886      887       +1     
- Misses        284      285       +1     
Impacted Files Coverage Δ
...s_dask/process_implementations/ml/random_forest.py 69.76% <66.66%> (-0.97%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LukeWeidenwalker LukeWeidenwalker merged commit afca7c6 into main Jul 14, 2023
3 of 5 checks passed
@LukeWeidenwalker LukeWeidenwalker deleted the move-heavy-imports-to-occur-at-runtime branch July 14, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant