-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support partial/incomplete batch job results #430 #433
Conversation
openapi.yaml
Outdated
The status of a batch job. | ||
|
||
This field is REQUIRED if the `partial` parameter is given. | ||
This field is strongly RECOMMENDED if the job has errored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this recommendation note for errored jobs?
You can only get a response with partial
on anyway, otherwise you get JobNotFinished
(line 3127 above)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also: I'm not sure "errored" is proper English (at least my spell checker complains)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this recommendation note for errored jobs? You can only get a response with
partial
on anyway, otherwise you getJobNotFinished
(line 3127 above)
Partial results can be exposed for jobs that errored stopped due to an error. In this case ideally, I'd require the status, too. But to not introduce a breaking change, it's just recommended for now.
I'm not sure "errored" is proper English
see above... ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart from a minor note about failed jobs, this looks ready to me
Implements suggestion from issue #430 as a parameter.