Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support partial/incomplete batch job results #430 #433

Merged
merged 4 commits into from
Dec 9, 2021
Merged

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Nov 30, 2021

Implements suggestion from issue #430 as a parameter.

@m-mohr m-mohr added job management incl. /result minor requires a minor-version (x.1.0 for example) platform labels Nov 30, 2021
@m-mohr m-mohr added this to the 1.2.0 milestone Nov 30, 2021
@m-mohr m-mohr requested a review from soxofaan November 30, 2021 16:41
@m-mohr m-mohr linked an issue Nov 30, 2021 that may be closed by this pull request
openapi.yaml Show resolved Hide resolved
openapi.yaml Outdated Show resolved Hide resolved
@m-mohr m-mohr self-assigned this Dec 1, 2021
@m-mohr m-mohr requested a review from soxofaan December 9, 2021 12:36
openapi.yaml Outdated
The status of a batch job.

This field is REQUIRED if the `partial` parameter is given.
This field is strongly RECOMMENDED if the job has errored.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this recommendation note for errored jobs?
You can only get a response with partial on anyway, otherwise you get JobNotFinished (line 3127 above)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also: I'm not sure "errored" is proper English (at least my spell checker complains)

Copy link
Member Author

@m-mohr m-mohr Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this recommendation note for errored jobs? You can only get a response with partial on anyway, otherwise you get JobNotFinished (line 3127 above)

Partial results can be exposed for jobs that errored stopped due to an error. In this case ideally, I'd require the status, too. But to not introduce a breaking change, it's just recommended for now.

I'm not sure "errored" is proper English

see above... ;-)

Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from a minor note about failed jobs, this looks ready to me

@m-mohr m-mohr mentioned this pull request Dec 9, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
job management incl. /result minor requires a minor-version (x.1.0 for example) platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support partial/incomplete batch job results
2 participants