Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job Results: STAC Collections instead of (or in addition to) Items #343

Closed
m-mohr opened this issue Nov 4, 2020 · 2 comments · Fixed by #359
Closed

Job Results: STAC Collections instead of (or in addition to) Items #343

m-mohr opened this issue Nov 4, 2020 · 2 comments · Fixed by #359
Assignees
Labels
breaking Breaking changes, requires a major-version (2.0.0 for example) job management incl. /result minor requires a minor-version (x.1.0 for example) platform PSC vote
Milestone

Comments

@m-mohr
Copy link
Member

m-mohr commented Nov 4, 2020

Due to the fact that Assets have only recently been added to STAC Collections, we currently return STAC Items in job results although it would likely make more sense to expose them as collections with optional items, depending on the data set that has been generated. Fortunately, the assets dict itself is fully compliant to Items.

@m-mohr m-mohr added this to the future milestone Nov 4, 2020
@m-mohr m-mohr added breaking Breaking changes, requires a major-version (2.0.0 for example) job management incl. /result labels Nov 4, 2020
@m-mohr
Copy link
Member Author

m-mohr commented Dec 17, 2020

This is something that probably needs to be done via openEO Platform.

@m-mohr m-mohr modified the milestones: future, 2.0.0 Dec 21, 2020
@m-mohr m-mohr changed the title Job Results: STAC Collections instead of Items Job Results: STAC Collections instead of (or in addition to) Items Feb 16, 2021
@m-mohr m-mohr self-assigned this Feb 16, 2021
@m-mohr
Copy link
Member Author

m-mohr commented Feb 17, 2021

I'll draft a (somewhat) backward-compatible PR for this as this is getting important.

The idea is to duplicate the assets into Collection Assets, for now, to have the assets available to all clients in a backward-compatible way. I'm checking the client implementations so that they rely on nothing else than assets. Result:

  • JS Client: ✔ getResultsAsItem will return something not very meaningful, but somehow handles it gracefully. Other methods work just fine. Will still issue a new version that handles it better.
  • Web Editor:😢 Will not correctly render the Collection results, but I'll implement that asap so that it shouldn't block anything.
  • R Client: ✔ Uses properties.expires, but it's implemented in a way that it ignores it if not set. Other than that just uses assets.
  • Demo App: ✔ Works smothly
  • Python client: ✔ Just uses assets, I don't see anything breaking

@m-mohr m-mohr added the minor requires a minor-version (x.1.0 for example) label Feb 17, 2021
@m-mohr m-mohr modified the milestones: 2.0.0, 1.1.0 Feb 17, 2021
@m-mohr m-mohr linked a pull request Feb 22, 2021 that will close this issue
3 tasks
@m-mohr m-mohr mentioned this issue Apr 8, 2021
6 tasks
m-mohr added a commit that referenced this issue Apr 19, 2021
* First draft for collections as job results #343
* Clarify job result descriptions #362 #363

Co-authored-by: Miha Kadunc <miha.kadunc@sinergise.com>
@m-mohr m-mohr closed this as completed Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes, requires a major-version (2.0.0 for example) job management incl. /result minor requires a minor-version (x.1.0 for example) platform PSC vote
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant