Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs: Add parameter for minimum severity #329

Closed
m-mohr opened this issue Jul 31, 2020 · 3 comments · Fixed by #431
Closed

Logs: Add parameter for minimum severity #329

m-mohr opened this issue Jul 31, 2020 · 3 comments · Fixed by #431
Assignees
Labels
job management incl. /result minor requires a minor-version (x.1.0 for example) service management
Milestone

Comments

@m-mohr
Copy link
Member

m-mohr commented Jul 31, 2020

It could be useful to filter logs returned to a client by a minimum severity. So for example, if I pass severity=warning to the back-end, it should only return warnings and errors, but not info or debug messages.

@m-mohr m-mohr added job management incl. /result service management minor requires a minor-version (x.1.0 for example) labels Jul 31, 2020
@soxofaan
Copy link
Member

soxofaan commented Sep 2, 2020

Do you mean filtering when retrieving the logs? This would imply that the backend always has to keep track of all log levels, which might not be desirable for large jobs (debug level might be very verbose).

Alternative (or additional) approach: user has to specify minimum log level (e.g warning by default) when submitting the job

@m-mohr
Copy link
Member Author

m-mohr commented Sep 2, 2020

Yes, I was speaking about the retrieval. If the back-end doesn't provide some levels, that is fine. The contract doesn't enforce any level. Allowing the user to select what he wants to log when submitting the process is also a good idea.

@m-mohr m-mohr added this to the future milestone Nov 25, 2020
@m-mohr m-mohr modified the milestones: future, 1.1.0 Dec 21, 2020
@m-mohr m-mohr modified the milestones: 1.1.0, future Apr 8, 2021
@m-mohr
Copy link
Member Author

m-mohr commented Nov 3, 2021

The idea of a job/service/...-specific flag for log-levels came up again in an internal discussion where @clausmichele proposed:

Could we add the info about each partial result in the log if a debug flag has been activated? [...]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
job management incl. /result minor requires a minor-version (x.1.0 for example) service management
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants