-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No requirements for GET /service_types #318
Comments
cc @bgoesswe |
Due to the "extensibility" of JSON, it's hard to avoid. I'd actually like to require configuration and process_parameters as it hopefully makes the back-end think what it needs to set ;-) and it's more explicit. Not sure whether we should introduce the breaking change in the release week though with just the reason to help the validator. It doesn't catch the invalid type as it's in an "undefined" structure, but it would be caught if it's in process_parameters. |
What I guess would be useful to have in the validator, that it reports "undefined" properties as warnings or so. @bgoesswe |
according to the openeo hub the support for secondary services is pretty thin (and so I assume practically unused), so I don't think a lot would break actually. But indeed it's already late to do these kind of things |
Indeed, just VITO and GEE. I'm fine with it and if VITO is fine with it, too. It really is not very useful to have nothing required at all. |
yes, it's not being used in a real application or use case at the moment, so we're open for minor breaking changes |
See PR #322. |
The service entries in
GET /service_types
currently have no required fields: each ofconfiguration
,process_parameters
andlinks
is allowed to be missing.This caused the validator to accept the 0.4-style version of this endpoint in the 1.0-version of the VITO backend, e.g. currently at http://openeo.vgt.vito.be/openeo/1.0/service_types:
Note these errors (that the validator didn't catch):
attributes
andparameters
"type": "a colormap to apply to single band layers"
Can this be avoided in some way?
For example require that
process_parameters
is present with at least and empty array?The text was updated successfully, but these errors were encountered: