Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error tagging #272

Closed
soxofaan opened this issue Apr 21, 2020 · 2 comments · Fixed by #275
Closed

Error tagging #272

soxofaan opened this issue Apr 21, 2020 · 2 comments · Fixed by #275
Milestone

Comments

@soxofaan
Copy link
Member

Any reason JobNotFound is tagged with Processes?

openeo-api/errors.json

Lines 256 to 263 in 1247172

"JobNotFound": {
"description": "The requested job does not exist.",
"message": "The job '{identifier}' does not exist.",
"http": 404,
"tags": [
"Job Management",
"Processes"
]

I'm also not sure it's necessary to put FileNotFound and FileContentInvalid under Processes

openeo-api/errors.json

Lines 123 to 130 in 1247172

"FileNotFound": {
"description": "The requested file does not exist.",
"message": "File '{file}' does not exist.",
"http": 404,
"tags": [
"File Management",
"Processes"
]

openeo-api/errors.json

Lines 173 to 180 in 1247172

"FileContentInvalid": {
"description": "The content of the file is invalid.",
"message": "File content is invalid.",
"http": 400,
"tags": [
"File Management",
"Processes"
]

@m-mohr
Copy link
Member

m-mohr commented Apr 21, 2020

"Processes" in that case meant that it could be thrown from executing a process, e.g. FileNotFound if a file specified to the run_udf function is not available. Although I'm not sure it's useful, because it's probably better to use ProcessArgumentInvalid with the reason being basically what FileNotFound says. So I'll probably remove these tags completely as nowadays it's usually also specified in processes themselves.

m-mohr added a commit that referenced this issue Apr 22, 2020
@m-mohr
Copy link
Member

m-mohr commented Apr 22, 2020

I realized the errors.json was quite outdated and the last major update was in 0.4 so took the chance to update it, see PR #275. It should incorporate the requested changes.

@m-mohr m-mohr linked a pull request Apr 22, 2020 that will close this issue
@m-mohr m-mohr closed this as completed Apr 23, 2020
@m-mohr m-mohr added this to the v1.0.0-final milestone Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants