Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connection race condition in connection locking? #13

Closed
soxofaan opened this issue Oct 8, 2021 · 1 comment
Closed

connection race condition in connection locking? #13

soxofaan opened this issue Oct 8, 2021 · 1 comment

Comments

@soxofaan
Copy link
Member

soxofaan commented Oct 8, 2021

When checking the logs I noticed some cases of

            raise LockedAuthException("Setting auth while locked.")

which should not happen normally.

I think it's possible however due to race conditions or object copying related to forking off the (gunicorn) workers, but needs more investigation.

@soxofaan
Copy link
Member Author

soxofaan commented Oct 12, 2021

Initial setup used 2 threads, but a couple of components in the aggregator are not thread safe at the moment: caches, the back-end-connections, ...

Using 1 thread per worker should resolve this problem.

In longer term it could be considered to make things thread safe, but at the moment it's just easier to add more (gunicorn) workers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant