Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable log/error output again if not running in daemon mode #44

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

bgn42
Copy link
Collaborator

@bgn42 bgn42 commented Apr 10, 2024

Addressing issue #43 enabled log and error output again.

Removed Message type at the beginning of a message.

Removed Message type at the beginning of a message.
Copy link

Test Results

  6 files  ±0   54 suites  ±0   4s ⏱️ ±0s
163 tests ±0  163 ✅ ±0  0 💤 ±0  0 ❌ ±0 
978 runs  ±0  978 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 01355df. ± Comparison against base commit 8ea2746.

Copy link

codeclimate bot commented Apr 10, 2024

Code Climate has analyzed commit 01355df and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 13.4% (35% is the threshold).

This pull request will bring the total coverage in the repository to 36.8% (-0.4% change).

View more on Code Climate.

Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let David review and decide!
I tried the cbridge output message locally when invoked via csolution.

csolution run -g CubeMX .\USB.csolution.yml -c 
HID.Debug
C:/workspace/EmbeddedWorld/EW24_MW_Examples/Boards/B-U585I-IOT02A/USB/Device/tmp/HID/B-U585I-IOT02A/Debug/USB.cbuild-gen-idx.yml - info csolution: file is already up-to-date
C:/workspace/EmbeddedWorld/EW24_MW_Examples/Boards/B-U585I-IOT02A/USB/Device/tmp/HID/B-U585I-IOT02A/Debug/HID.Debug+B-U585I-IOT02A.cbuild-gen.yml - info csolution: file is already up-to-date
info csolution: generator 'CubeMX' for context 'HID.Debug+B-U585I-IOT02A' reported:
Launching STM32CubeMX with  C:/workspace/EmbeddedWorld/EW24_MW_Examples/Boards/B-U585I-IOT02A/USB/Device/HID/STM32CubeMX/B-U585I-IOT02A/STM32CubeMX/STM32CubeMX.ioc

and if CubeMX cannot be launched:

info csolution: generator 'CubeMX' for context 'HID.Debug+B-U585I-IOT02A' reported:
Launching STM32CubeMX with  C:/workspace/EmbeddedWorld/EW24_MW_Examples/Boards/B-U585I-IOT02A/USB/Device/HID/STM32CubeMX/B-U585I-IOT02A/STM32CubeMX/STM32CubeMX.ioc
Error : generator 'CubeMX' missing. Install from 'https://www.st.com/en/development-tools/stm32cubemx.html#st-get-software'

error csolution: executing generator 'CubeMX' for context 'HID.Debug+B-U585I-IOT02A' failed

Copy link
Collaborator

@DavidLesnjak DavidLesnjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion it looks better with log message.

@bgn42 bgn42 merged commit cc63249 into main Apr 12, 2024
20 checks passed
@bgn42 bgn42 deleted the logging branch April 12, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants