Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated generation of MX_Device.h #41

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Updated generation of MX_Device.h #41

merged 2 commits into from
Mar 22, 2024

Conversation

DavidLesnjak
Copy link
Collaborator

  • Renamed folder for generated MX_Device.h (from drv_cfg to MX_Device)
  • Added MX_Device version
  • Added USB device handle
  • Peripherals and configurations are listed in alphabetical order
  • Changed header guard from MX_DEVICE_H to MX_DEVICE_H

@DavidLesnjak
Updated generation of MX_Device.h
b9ee613 
- Added MX_Device version
- Added USB device handle
- Peripherals and configurations are listed in alphabetical order
- Changed header guard from __MX_DEVICE_H to MX_DEVICE_H__
@DavidLesnjak
Renamed folder for generated MX_Device.h (from drv_cfg to MX_Device)
24cfdfd
@github-actions GitHub Actions
Copy link

Test Results

  6 files  ±0   54 suites  ±0   4s ⏱️ ±0s
163 tests ±0  163 ✅ ±0  0 💤 ±0  0 ❌ ±0 
978 runs  ±0  978 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 24cfdfd. ± Comparison against base commit 660fe34.

@codeclimate CodeClimate
Copy link

codeclimate bot commented Mar 22, 2024

Code Climate has analyzed commit 24cfdfd and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 39.1% (35% is the threshold).

This pull request will bring the total coverage in the repository to 37.9% (-0.3% change).

View more on Code Climate.

@DavidLesnjak DavidLesnjak requested a review from bgn42 March 22, 2024 14:05
jkrech
jkrech reviewed Mar 22, 2024
View reviewed changes
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I let Bernd to provide approval.

bgn42
bgn42 approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@bgn42 bgn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, now the pins are sorted. Very good. And the directory name of drv_cfg has changed?

@jkrech jkrech merged commit 9a79318 into main Mar 22, 2024
20 checks passed
@jkrech jkrech deleted the mxDeviceh branch March 25, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkrech jkrech jkrech left review comments

@bgn42 bgn42 bgn42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidLesnjak @jkrech @bgn42