Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all tests under subdirectories #25

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Run all tests under subdirectories #25

merged 1 commit into from
Feb 2, 2024

Conversation

soumeh01
Copy link
Collaborator

@soumeh01 soumeh01 commented Feb 2, 2024

No description provided.

Copy link

github-actions bot commented Feb 2, 2024

Test Results

  6 files  ±0   54 suites  ±0   3s ⏱️ -1s
 71 tests ±0   71 ✅ ±0  0 💤 ±0  0 ❌ ±0 
426 runs  ±0  426 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f54a80f. ± Comparison against base commit 72d4987.

@soumeh01 soumeh01 requested a review from bgn42 February 2, 2024 08:00
Copy link
Collaborator Author

@soumeh01 soumeh01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgn42 Due to historical structural reasons, the test command was running only in a specific directory and covering the related code. I have fixed it to run it under all the directories. The coverage step will still fail because the target set is 85%.

Copy link
Collaborator

@bgn42 bgn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The coverage will increase in near future :-)

@bgn42 bgn42 merged commit 16c3b72 into main Feb 2, 2024
19 of 20 checks passed
@jkrech jkrech deleted the coverage_check branch September 13, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants