Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing required pack msg #1788

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

spcaipers-arm
Copy link
Collaborator

@spcaipers-arm spcaipers-arm commented Sep 27, 2024

Addressed: #1702

Copy link

github-actions bot commented Sep 27, 2024

Test Results

    3 files     18 suites   8m 13s ⏱️
  371 tests   371 ✅ 0 💤 0 ❌
1 113 runs  1 113 ✅ 0 💤 0 ❌

Results for commit 11179a2.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soumeh01 soumeh01 merged commit 18f4b02 into Open-CMSIS-Pack:main Oct 1, 2024
33 checks passed
@soumeh01 soumeh01 deleted the outbound/pack_missing branch October 1, 2024 15:23
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.24%. Comparing base (4321cd8) to head (11179a2).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
tools/projmgr/test/src/ProjMgrUnitTests.cpp 84.61% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1788      +/-   ##
==========================================
+ Coverage   64.23%   64.24%   +0.01%     
==========================================
  Files         163      163              
  Lines       32108    32127      +19     
  Branches    19626    19635       +9     
==========================================
+ Hits        20624    20641      +17     
+ Misses       7522     7517       -5     
- Partials     3962     3969       +7     
Flag Coverage Δ
projmgr-cov 81.07% <90.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/src/ProjMgrWorker.cpp 87.62% <100.00%> (+0.02%) ⬆️
tools/projmgr/test/src/ProjMgrUnitTests.cpp 79.94% <84.61%> (+0.01%) ⬆️

... and 18 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants