Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[projmgr] Set cdefault compiler deprecation warning (#1029) #1764

Conversation

grasci-arm
Copy link
Collaborator

@grasci-arm grasci-arm commented Sep 13, 2024

Address #1698

Note that removing a schema property from a node that does not allow additional properties is a breaking change.
For this reason select-compiler can only be removed in the next major release. Schema descriptions with the deprecation message were added instead.

Copy link

Test Results

    3 files     18 suites   8m 19s ⏱️
  368 tests   368 ✅ 0 💤 0 ❌
1 104 runs  1 104 ✅ 0 💤 0 ❌

Results for commit b4712d6.

Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkrech jkrech merged commit 82db08e into Open-CMSIS-Pack:main Sep 13, 2024
33 checks passed
@jkrech jkrech deleted the outbound/projmgr-cdefault-compiler-select branch September 13, 2024 10:01
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.39%. Comparing base (aeb3e69) to head (b4712d6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1764   +/-   ##
=======================================
  Coverage   76.39%   76.39%           
=======================================
  Files         163      163           
  Lines       32072    32074    +2     
  Branches    19606    19608    +2     
=======================================
+ Hits        24502    24504    +2     
  Misses       7551     7551           
  Partials       19       19           
Flag Coverage Δ
projmgr-cov 96.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/src/ProjMgrYamlParser.cpp 91.04% <100.00%> (+0.02%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants