Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[projmgr] Add pack related access sequences handling #1679

Conversation

grasci-arm
Copy link
Collaborator

@grasci-arm grasci-arm commented Aug 1, 2024

Handle $Dpack$, $Bpack$ and $Pack(vendor::name)$ access sequences as documented in:
https://github.com/Open-CMSIS-Pack/cmsis-toolbox/blob/main/docs/YML-Input-Format.md#access-sequences

Note: use :: as delimiter instead of ., as established by pack name conventions.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 63.86%. Comparing base (6cdfdd7) to head (7c3a5f7).

Files Patch % Lines
tools/projmgr/src/ProjMgrWorker.cpp 75.75% 1 Missing and 7 partials ⚠️
tools/projmgr/test/src/ProjMgrUnitTests.cpp 87.50% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1679      +/-   ##
==========================================
+ Coverage   63.81%   63.86%   +0.04%     
==========================================
  Files         162      162              
  Lines       31599    31636      +37     
  Branches    19364    19392      +28     
==========================================
+ Hits        20166    20203      +37     
+ Misses       7530     7527       -3     
- Partials     3903     3906       +3     
Flag Coverage Δ
buildmgr-cov 74.21% <ø> (ø)
packchk-cov 65.54% <ø> (ø)
projmgr-cov 80.72% <80.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
tools/projmgr/test/src/ProjMgrWorkerUnitTests.cpp 65.88% <100.00%> (+0.02%) ⬆️
tools/projmgr/test/src/ProjMgrUnitTests.cpp 79.46% <87.50%> (+0.03%) ⬆️
tools/projmgr/src/ProjMgrWorker.cpp 87.13% <75.75%> (+0.15%) ⬆️

... and 7 files with indirect coverage changes

Copy link

github-actions bot commented Aug 1, 2024

Test Results

  7 files   53 suites   4m 50s ⏱️
185 tests 168 ✅ 17 💤 0 ❌
692 runs  624 ✅ 68 💤 0 ❌

Results for commit 7c3a5f7.

♻️ This comment has been updated with latest results.

@brondani
Copy link
Collaborator

brondani commented Aug 1, 2024

@ReinhardKeil Please update the documentation accordingly.

@brondani brondani merged commit c566006 into Open-CMSIS-Pack:main Aug 1, 2024
84 checks passed
@brondani brondani deleted the outbound/projmgr-add-pack-access-sequences branch August 1, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants