Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for external generators in RTE Model #1309

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

grasci-arm
Copy link
Collaborator

  • Support for external generators in RTE Model
    read .generator.yml files
    make some common code accessible from different tools
    remove duplicated methods
    read generators.yml in RTE Model
    move ExecCommand to CrossPlatformUtils
    move constants to RteConstants
    move some utility methods to CollectionUtils
    rename RteFsUtils::CreateFile to RteFsUtils::CreateTextFile due to clash with Windows API

* Support for external generators in RTE Model
read .generator.yml files
make some common code accessible from different tools
remove duplicated methods
read generators.yml  in RTE Model
move ExecCommand to CrossPlatformUtils
move constants to RteConstants
move some utility methods to CollectionUtils
rename RteFsUtils::CreateFile to RteFsUtils::CreateTextFile due to clash with Windows API
Copy link

github-actions bot commented Feb 2, 2024

Test Results

  7 files   53 suites   5m 23s ⏱️
188 tests 171 ✅ 17 💤 0 ❌
701 runs  633 ✅ 68 💤 0 ❌

Results for commit d326d3d.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (5572be9) 59.26% compared to head (d326d3d) 59.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1309      +/-   ##
==========================================
- Coverage   59.26%   59.06%   -0.21%     
==========================================
  Files         117      117              
  Lines       23550    23438     -112     
  Branches    13117    13070      -47     
==========================================
- Hits        13958    13844     -114     
- Misses       7338     7347       +9     
+ Partials     2254     2247       -7     
Flag Coverage Δ
buildmgr-cov 77.86% <100.00%> (-0.06%) ⬇️
packchk-cov 64.16% <0.00%> (ø)
packgen-cov 81.53% <42.85%> (-0.19%) ⬇️
projmgr-cov 84.30% <84.72%> (-0.33%) ⬇️
svdconv-cov 38.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
tools/buildmgr/cbuild/src/CbuildModel.cpp 72.23% <100.00%> (ø)
tools/buildmgr/cbuild/src/CbuildUtils.cpp 79.59% <ø> (-0.90%) ⬇️
...ls/buildmgr/cbuildgen/src/BuildSystemGenerator.cpp 85.21% <100.00%> (ø)
tools/projmgr/src/ProjMgrGenerator.cpp 89.17% <100.00%> (ø)
tools/projmgr/src/ProjMgrYamlParser.cpp 75.03% <100.00%> (-1.82%) ⬇️
tools/packchk/src/PackChk.cpp 66.00% <0.00%> (ø)
tools/projmgr/src/ProjMgr.cpp 77.67% <33.33%> (+0.29%) ⬆️
tools/projmgr/src/ProjMgrExtGenerator.cpp 86.00% <75.00%> (-0.16%) ⬇️
tools/projmgr/src/ProjMgrUtils.cpp 89.77% <80.00%> (+1.46%) ⬆️
tools/packgen/src/PackGen.cpp 81.53% <42.85%> (-0.19%) ⬇️
... and 2 more

... and 1 file with indirect coverage changes

@edriouk edriouk changed the title Support for external generators in RTE Model (#780) Support for external generators in RTE Model Feb 2, 2024
@edriouk edriouk merged commit 8b3b1eb into Open-CMSIS-Pack:main Feb 2, 2024
115 of 118 checks passed
@edriouk edriouk deleted the outbound/extGenRte branch February 2, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants