Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpackget] Encoded progress, when tool is called from other tools #188

Merged
merged 11 commits into from
Jun 28, 2023

Conversation

thorstendb-ARM
Copy link
Collaborator

@thorstendb-ARM thorstendb-ARM commented Jun 27, 2023

Usage:
Available for commands: init, add, update-index: "--encoded-progress"
e.g.: cpackget add Keil::STM32C0xx_DFP --encoded-progress

/* Encodes information to show progress when called by GUI or other tools
 * I: Instance number (always counts up), connected to the filename
 * F: Filename currently processed
 * T: Total bytes of file or numbers of files
 * P: Currently processed percentage
 * C: Currently processed bytes or numbers of files */

Copy link
Collaborator

@soumeh01 soumeh01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, Can you add in the description, the complete updated command line usage with the new options? It will be easy to review and visualize.

@thorstendb-ARM
Copy link
Collaborator Author

If possible, Can you add in the description, the complete updated command line usage with the new options? It will be easy to review and visualize.

done.

Usage: --encoded-progress

/* Encodes information to show progress when called by GUI or other tools
 * I: Instance number (always counts up), connected to the filename
 * F: Filename currently processed
 * T: Total bytes of file or numbers of files
 * P: Currently processed percentage
 * C: Currently processed bytes or numbers of files
 */
cmd/commands/root.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Patch coverage: 65.57% and project coverage change: -0.06 ⚠️

Comparison is base (c37837d) 79.06% compared to head (c24e8db) 79.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   79.06%   79.00%   -0.06%     
==========================================
  Files          21       22       +1     
  Lines        2522     2572      +50     
==========================================
+ Hits         1994     2032      +38     
- Misses        391      399       +8     
- Partials      137      141       +4     
Impacted Files Coverage Δ
cmd/commands/checksum.go 85.71% <ø> (ø)
cmd/commands/signature.go 97.18% <ø> (ø)
cmd/installer/pack.go 77.36% <15.38%> (-0.99%) ⬇️
cmd/utils/utils.go 84.82% <28.57%> (-1.44%) ⬇️
cmd/commands/add.go 90.32% <100.00%> (+0.49%) ⬆️
cmd/commands/init.go 85.00% <100.00%> (+2.64%) ⬆️
cmd/commands/root.go 67.03% <100.00%> (ø)
cmd/commands/update_index.go 95.00% <100.00%> (+0.55%) ⬆️
cmd/utils/encodedProgress.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

soumeh01
soumeh01 previously approved these changes Jun 28, 2023
I: [I0:F"C:\Users\xxx\AppData\Local\Arm\Packs\.Download\Keil.STM32C0xx_DFP.1.0.0.pack",T474,P1]
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thorstendb-ARM thorstendb-ARM merged commit 64c7ae5 into main Jun 28, 2023
14 checks passed
@thorstendb-ARM thorstendb-ARM deleted the encodedProgress branch June 28, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants