Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use keil.com/pack/ as default address to fetch PDSC files #183

Merged
merged 7 commits into from
Jun 20, 2023

Conversation

thorstendb-ARM
Copy link
Collaborator

@thorstendb-ARM thorstendb-ARM commented Jun 16, 2023

Switching to "https://www.keil.com/pack/" if index.pidx was downloaded from there, to fetch PDSC files.
Assumption: fetching from this location is faster and more reliable (PDSCs are verified), and PDSC files are always cached there (lags prob. up to 1 day).

Test (today): Fetching "as is" takes around 1:50 min, redirecting all PDSCs to keil.com takes around 2:30 min.
"args": ["init", "https://www.keil.com/pack/index.pidx", "-a", "-v",]

See #182

Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I am not an expert in GO.

Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkrech jkrech self-requested a review June 20, 2023 11:08
@jkrech jkrech merged commit e0ac8ba into main Jun 20, 2023
@jkrech jkrech deleted the useKeilcomCach branch June 20, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants