Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create log file parent path #80

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Create log file parent path #80

merged 2 commits into from
Aug 11, 2023

Conversation

soumeh01
Copy link
Collaborator

@soumeh01 soumeh01 commented Aug 10, 2023

Addressing: Open-CMSIS-Pack/devtools#1042

  • If the path doesn't exist, create a log file path
  • Throws an error, when unable to create a directory or file
  • Stop the execution in case of an error

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2023

Test Results

    4 files  ±0    36 suites  ±0   3s ⏱️ -1s
135 tests +2  135 ✔️ +2  0 💤 ±0  0 ±0 
540 runs  +8  540 ✔️ +8  0 💤 ±0  0 ±0 

Results for commit 85a6e97. ± Comparison against base commit 413e577.

This pull request removes 2 and adds 4 tests. Note that renamed tests count towards both.
cbuild/cmd/cbuild/commands ‑ TestPreLogConfiguration/test_invalid_path_to_log_file
cbuild/cmd/cbuild/commands/build ‑ TestPreLogConfiguration/test_invalid_path_to_log_file
cbuild/cmd/cbuild/commands ‑ TestPreLogConfiguration/test_invalid_log_file_path_error
cbuild/cmd/cbuild/commands ‑ TestPreLogConfiguration/test_log_file_creation_error
cbuild/cmd/cbuild/commands ‑ TestPreLogConfiguration/test_path_generation_to_log_file
cbuild/cmd/cbuild/commands/build ‑ TestPreLogConfiguration/test_path_generation_to_log_file

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Patch coverage: 72.72% and project coverage change: -0.22% ⚠️

Comparison is base (413e577) 72.86% compared to head (85a6e97) 72.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   72.86%   72.65%   -0.22%     
==========================================
  Files          13       13              
  Lines        1021     1024       +3     
==========================================
  Hits          744      744              
- Misses        232      234       +2     
- Partials       45       46       +1     
Files Changed Coverage Δ
cmd/cbuild/commands/root.go 86.45% <72.72%> (-1.71%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soumeh01 soumeh01 force-pushed the log_option branch 2 times, most recently from 63c2988 to b6b1193 Compare August 11, 2023 09:04
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkrech jkrech merged commit 32fb9a0 into main Aug 11, 2023
11 checks passed
@jkrech jkrech deleted the log_option branch August 11, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants