Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove $CMSIS_BUILD_ROOT references and test structure cleanup #77

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

soumeh01
Copy link
Collaborator

@soumeh01 soumeh01 commented Aug 2, 2023

Addressing issue : #73

@soumeh01 soumeh01 marked this pull request as draft August 2, 2023 13:38
@soumeh01 soumeh01 changed the title Remove CMSIS_BUILD_ROOT references and test structure cleanup [WIP] Remove CMSIS_BUILD_ROOT references and test structure cleanup Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Test Results

    4 files  ±0    36 suites  +4   3s ⏱️ -3s
133 tests  - 2  133 ✔️  - 2  0 💤 ±0  0 ±0 
532 runs   - 8  532 ✔️  - 8  0 💤 ±0  0 ±0 

Results for commit 27e510a. ± Comparison against base commit 851a530.

This pull request removes 4 and adds 2 tests. Note that renamed tests count towards both.
cbuild/pkg/builder/cproject ‑ TestGetInternalVars/test_get_internal_vars,_with_CMSIS_BUILD_ROOT
cbuild/pkg/builder/cproject ‑ TestGetInternalVars/test_get_internal_vars,_without_CMSIS_BUILD_ROOT
cbuild/pkg/utils ‑ TestGetInstallConfigs/test_get_install_configs_with_CMSIS_BUILD_ROOT
cbuild/pkg/utils ‑ TestGetInstallConfigs/test_get_install_configurations_without_CMSIS_BUILD_ROOT
cbuild/pkg/builder/cproject ‑ TestGetInternalVars/test_get_internal_vars
cbuild/pkg/utils ‑ TestGetInstallConfigs/test_get_install_configurations

♻️ This comment has been updated with latest results.

@soumeh01 soumeh01 changed the title [WIP] Remove CMSIS_BUILD_ROOT references and test structure cleanup Remove $CMSIS_BUILD_ROOT references and test structure cleanup Aug 3, 2023
@soumeh01 soumeh01 marked this pull request as ready for review August 3, 2023 07:20
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 50.00% and project coverage change: -4.28% ⚠️

Comparison is base (851a530) 77.14% compared to head (27e510a) 72.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   77.14%   72.86%   -4.28%     
==========================================
  Files          13       13              
  Lines        1028     1021       -7     
==========================================
- Hits          793      744      -49     
- Misses        185      232      +47     
+ Partials       50       45       -5     
Files Changed Coverage Δ
pkg/utils/configs.go 50.00% <33.33%> (-25.00%) ⬇️
pkg/utils/utils.go 81.56% <100.00%> (-0.64%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soumeh01 soumeh01 requested a review from jkrech August 3, 2023 07:58
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soumeh01 soumeh01 merged commit 8b1f4cc into main Aug 3, 2023
11 checks passed
@soumeh01 soumeh01 deleted the cmsis_build_root branch August 3, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants