Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI updates #485

Merged
merged 20 commits into from
Feb 5, 2025
Merged

UI updates #485

merged 20 commits into from
Feb 5, 2025

Conversation

anna-st-40
Copy link
Collaborator

Made some of the changes discussed with Dr. Onthank, including:

  • Simplifying & updating tank snapshot graphs
  • Adding more visible setpoint lines
  • Adding a pH/temperature option selector when viewing graph
  • Replacing circular loaders with skeleton loaders

Also, the snapshot API on the log file server now accepts parameters, with a default of 12 hours.

@anna-st-40
Added button to redirect to Tank Monitor / Tank Manager
d8848be
@anna-st-40
Removed animation of graph
6cf939e
@anna-st-40
Option selector for ph/temp
2783d89
@anna-st-40
Merge branch 'main' of https://github.com/Open-Acidification/TankCont…
2b981f1 
…roller into ui-dev
@anna-st-40
working on toggle button
81337eb
@anna-st-40
Updated server and test logs
6326384
@anna-st-40
Changed snapshot default to 12 hours
1de8837
@anna-st-40
TankSnapshot now also has setpoints
90aac3e
@anna-st-40
Updated/refactored tank cards
ae73740
@anna-st-40
Added skeleton loaders instead of progress indicators
b12a848
@anna-st-40
Refactored toggle button
eafbaca
@anna-st-40
Made setpoint lines more visible
4283986
@anna-st-40
Updated snapshot graphs
d0ce059
@anna-st-40
Removed redirect button - web package interferes with flutter tests
8b41565
@anna-st-40
Updated tests for 12-hour-default snapshots
d2e0581
@anna-st-40
Formatted all code
346f836
@anna-st-40
Removed redirect button - web package interferes with flutter tests
743a2c8
@anna-st-40
Fixed test failure (did not update test after updating data)
37dfa94
jgfoster
jgfoster requested changes Feb 5, 2025
View reviewed changes
Copy link
Member

@jgfoster jgfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor requests...

extras/device_client/lib/view/home_page.dart Show resolved Hide resolved
extras/log_file_client/lib/components/graph_view.dart Show resolved Hide resolved
extras/log_file_client/lib/pages/home_page.dart Show resolved Hide resolved
extras/log_file_client/lib/utils/http_client.dart Outdated Show resolved Hide resolved
extras/log_file_client/logs/index.html Outdated Show resolved Hide resolved
jgfoster
jgfoster approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@jgfoster jgfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thanks!

@jgfoster jgfoster merged commit d569978 into Open-Acidification:main Feb 5, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgfoster jgfoster jgfoster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anna-st-40 @jgfoster