Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven fixes #45

Merged
merged 13 commits into from
Apr 18, 2020
Merged

Maven fixes #45

merged 13 commits into from
Apr 18, 2020

Conversation

tgoprince
Copy link
Member

I adjusted the project structure and the maven files to improve the developer experience.

Everything should be understable from the README.md, so please take a look and let me know if you are able to follow.

@victorviola
Copy link
Contributor

Removed the .m2 repositories and installed as recommended by the Readme and worked like a charm.
This can be merged.

@claudenirmf
Copy link
Member

claudenirmf commented Apr 14, 2020

I have updated the script to enable debugging with VS Code.

I also had issues because the script expected a specific installation of java, so I changed it to get the installation dynamically. @tgoprince , please try it on your machine. btw, does mvn exec:exec also work on Windows? If not, we need to make that clear on the README.

@victorviola, did you make changes to this project? From your comment, it seems that you forgot to commit it.

@victorviola
Copy link
Contributor

Hi @claudenirmf,
The repositories I mentioned are the ones located in my machine. No changes in the project.

@claudenirmf
Copy link
Member

claudenirmf commented Apr 14, 2020 via email

@tgoprince
Copy link
Member Author

I tried all the commands and everything is working fine.

I also adjusted the READ as suggested by @claudenirmf

@victorviola could you create something analogous to scripts\run.sh for windows (a run.cmd)?

@tgoprince
Copy link
Member Author

I just added two build profiles in our pom.xml activated by the OS. One for Linux/macOs and another for Windows.

@victorviola: I already set up everything, you just need to edit the contents of scripts/run-vp.cmd

@victorviola
Copy link
Contributor

After all changes we are good to go. Working on windows/linux and macOS.

@victorviola victorviola merged commit ca9dffb into development Apr 18, 2020
@victorviola victorviola deleted the maven-fixes branch April 18, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants