Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Log Panel and Highlight element models #32

Merged
merged 8 commits into from
Mar 24, 2020

Conversation

victorviola
Copy link
Contributor

@victorviola victorviola commented Mar 22, 2020

  • Created a custom log panel for the verification service.
  • Created a context menu in the log panel
  • User can now highlight or open specification for the given faulty element according to the verification service.

This PR solves issues #20 and #24.

@claudenirmf
Copy link
Member

claudenirmf commented Mar 22, 2020

I have updated the code to enable the "Open Specification" action.
I have also updated the code to highlight the diagram element of the active diagram or the master view.

There is still an issue regarding the presentation of issues, there is a lot of space between items. Could you please check that out?

image

In addition, you don't have to crawl the model to get the elements you desire if you already have something to work with, for instance, the model element's is. Have a look at these methods:

project.getDiagramById(diagramElementId);
project.getModelElementById(modelElement);
modelElement.getDiagramElements();
diagramElement.getModelElement();

If my comment was confusing, you could have a look at how I modified openSpecDiagramElement() and highlightDiagramElement() in my last commit.

@claudenirmf claudenirmf self-requested a review March 22, 2020 22:01
@claudenirmf
Copy link
Member

My lastest commit seeks to help with feedback to the user so it is easier to discover this feature. It changes the following:

  • Hovering over an issue changes its background color to light gray
  • Both left and right clicks bring the context menu

image

Please verify if my changes introduce any cross-platform issues.

Btw, maybe you could solve the size issue by using JList instead of JTextArea.

@claudenirmf
Copy link
Member

Adapted hovering selection

Screen Recording 2020-03-23 at 21 50 00

@victorviola victorviola merged commit 35d626c into development Mar 24, 2020
@victorviola victorviola deleted the issue20-custom-log-panel branch March 24, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants