-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 8 new models and updates #286
Conversation
models/alkhalaf2024/metadata.yaml
Outdated
context: | ||
- research | ||
source: | ||
- https://tinyurl.com/5n8c7k8t |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not use a GoogleDrive link with some images as the source. It should, instead, be the paper which includes these figures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
source substituted to https://dx.doi.org/10.5220/0000178400003598
landingPage removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O DOI que você adicionou não resolve para o artigo, mas para o proceedings que inclui o artigo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing! Fixed.
representationStyle: | ||
- ontouml | ||
landingPage: | ||
- https://essay.utwente.nl/101204/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a landing page. Please remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URL substituted by another that contains complementary information about the ontology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments on the files.
@tgoprince, thank you for the review. All recommended adjustments have been made. Can you please review the PR again? The modifications made were basically:
|
…into resiliont
@tgoprince , I fixed the mgic2011 dataset, which had non-OntoUML models. You can review it now. |
I found two URIs for MIT licenses: Let's stick with one of them? |
The file The link also resolves to a folder containing only some diagrams in png files. This does not fit the definition of landing page we agreed upon for this project. |
Yes. Thanks for noticing. The correct one is https://opensource.org/license/mit. I am making the necessary substitutions. |
The DCAT 3's definition of landing page is:
The Google Drive's page do contain additional information about the model. Shouldn't we consider it as a valid landing page? Please reconsider. |
@tgoprince, I addressed all the mentioned problems. Please check whether I should remove of not sariev2024's landing page. If you still believe it is the best option, let me know and then I will remove it asap. |
@pedropaulofb, the Google Drive link redirects to a page contain tree pdfs, each of which contain a single diagram. It does not even provide access to the actual file containing the model. Moreover, Google Drive links are very easily broken. I honestly, do not see any value of keeping this link as is. I suggest we reject temporary URLs like this one all the metadata fields we collect. |
Ok! I already removed the URL from the metadata. |
Eight new models added. All models were sent via the catalog's Google Forms after we got in contact with the authors.
Model updated:
All
ttl
files with the outdatedpurl.org
Catalog URIs have been updated to the latestw3id.org
URI.