Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 8 new models and updates #286

Merged
merged 18 commits into from
Oct 16, 2024
Merged

Add 8 new models and updates #286

merged 18 commits into from
Oct 16, 2024

Conversation

pedropaulofb
Copy link
Member

@pedropaulofb pedropaulofb commented Sep 2, 2024

Eight new models added. All models were sent via the catalog's Google Forms after we got in contact with the authors.

  • alkhalaf2024
  • barcelos2024resiliont
  • elghosh2024eucaim
  • nascimento2023spacecon
  • piest2024dsr-kb
  • pinheiro2024api
  • sariev2024maritime
  • schoonderbeek2024eamon

Model updated:

  • xhani2023xmlpo

All ttl files with the outdated purl.org Catalog URIs have been updated to the latest w3id.org URI.

@pedropaulofb pedropaulofb changed the title Add Resiliont Add 8 new models and updates Sep 4, 2024
context:
- research
source:
- https://tinyurl.com/5n8c7k8t
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not use a GoogleDrive link with some images as the source. It should, instead, be the paper which includes these figures.

http://doi.org/10.5220/0012183900003598

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
source substituted to https://dx.doi.org/10.5220/0000178400003598
landingPage removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O DOI que você adicionou não resolve para o artigo, mas para o proceedings que inclui o artigo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing! Fixed.

representationStyle:
- ontouml
landingPage:
- https://essay.utwente.nl/101204/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a landing page. Please remove.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL substituted by another that contains complementary information about the ontology.

Copy link
Member

@tgoprince tgoprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments on the files.

@pedropaulofb
Copy link
Member Author

pedropaulofb commented Sep 10, 2024

@tgoprince, thank you for the review. All recommended adjustments have been made. Can you please review the PR again?

The modifications made were basically:

  • fix all purl.org URIs (except from DC terms)
  • fix reported landingPages and source pages
  • minor fixes resultant from the transformation to ttl

@pedropaulofb
Copy link
Member Author

@tgoprince , I fixed the mgic2011 dataset, which had non-OntoUML models. You can review it now.

@tgoprince
Copy link
Member

I found two URIs for MIT licenses:

Let's stick with one of them?

@tgoprince
Copy link
Member

tgoprince commented Oct 15, 2024

The file sariev2024/metadata.yaml contains a google drive link as a landing page:
https://drive.google.com/drive/folders/1Y0ZbJ1RgKvVJZWORznzWLptFPQN5G2m5

The link also resolves to a folder containing only some diagrams in png files.

This does not fit the definition of landing page we agreed upon for this project.

@pedropaulofb
Copy link
Member Author

I found two URIs for MIT licenses:

Let's stick with one of them?

Yes. Thanks for noticing. The correct one is https://opensource.org/license/mit.

I am making the necessary substitutions.

@pedropaulofb
Copy link
Member Author

The file sariev2024/metadata.yaml contains a google drive link as a landing page: https://drive.google.com/drive/folders/1Y0ZbJ1RgKvVJZWORznzWLptFPQN5G2m5

The link also resolves to a folder containing only some diagrams in png files.

This does not fit the definition of landing page we agreed upon for this project.

The DCAT 3's definition of landing page is:

A Web page that can be navigated to in a Web browser to gain access to the catalog, a dataset, its distributions and/or additional information.

The Google Drive's page do contain additional information about the model. Shouldn't we consider it as a valid landing page? Please reconsider.

@pedropaulofb
Copy link
Member Author

@tgoprince, I addressed all the mentioned problems. Please check whether I should remove of not sariev2024's landing page. If you still believe it is the best option, let me know and then I will remove it asap.

@tgoprince
Copy link
Member

@pedropaulofb, the Google Drive link redirects to a page contain tree pdfs, each of which contain a single diagram. It does not even provide access to the actual file containing the model. Moreover, Google Drive links are very easily broken. I honestly, do not see any value of keeping this link as is.

I suggest we reject temporary URLs like this one all the metadata fields we collect.

@pedropaulofb
Copy link
Member Author

@pedropaulofb, the Google Drive link redirects to a page contain tree pdfs, each of which contain a single diagram. It does not even provide access to the actual file containing the model. Moreover, Google Drive links are very easily broken. I honestly, do not see any value of keeping this link as is.

I suggest we reject temporary URLs like this one all the metadata fields we collect.

Ok! I already removed the URL from the metadata.

@tgoprince tgoprince merged commit 83b71f0 into master Oct 16, 2024
1 check passed
@tgoprince tgoprince deleted the resiliont branch October 16, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants