Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RA: New in-game menu button action: "Quick menu" + fix quitting RetroArch from arcade games #1620

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

Aemiii91
Copy link
Member

Changes

  • Add option in Tweaks:
    • In-game: Menu button - ... < Quick menu >
    • Toggles RetroArch's quick menu
  • Use UDP protocol to exit RetroArch
    • Fixes issues with exiting from arcade games

Try it

Test patch available here: Onion_v4.3.1-1__menu_button_UDP_actions.zip

@mahoneyt944
Copy link

mahoneyt944 commented Aug 8, 2024

Does this work instead?
libretro/RetroArch#16854

Copy link
Member

@tGecko tGecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both Quick menu and exiting games tested, works fine! Seems to fix Arcade exiting for good 👍🏻

@mahoneyt944
Copy link

mahoneyt944 commented Oct 18, 2024

Both Quick menu and exiting games tested, works fine! Seems to fix Arcade exiting for good 👍🏻

Does libretro/RetroArch#16854 fix this issue? This PR shouldn't be necessary if that PR is working properly within RA.

@tGecko
Copy link
Member

tGecko commented Oct 18, 2024

Both Quick menu and exiting games tested, works fine! Seems to fix Arcade exiting for good 👍🏻

Does libretro/RetroArch#16854 fix this issue? This PR shouldn't be necessary if that PR is working properly within RA.

Possibly, but I don't know when we will update our RA fork. This works, is simple, and we will use the UDP commands for other things as well, like showing the RA menu, which is included in this PR

@mahoneyt944
Copy link

This is certainly a case of "if it works it works", however adding to the dingux input driver for your device so that RA can read the menu button directly (or anything else for that matter) would be a much better approach than hacking the network interface in general. You could also just pull that one change into the project without updating RA entirely as well for this instance.

@Aemiii91 Aemiii91 added this pull request to the merge queue Dec 22, 2024
Merged via the queue into main with commit d40c76a Dec 22, 2024
2 checks passed
@Aemiii91 Aemiii91 deleted the menu-button-udp-commands branch December 22, 2024 18:42
@Aemiii91 Aemiii91 changed the title New in-game menu button action: "Quick menu" + fix quitting RetroArch from arcade games RA: New in-game menu button action: "Quick menu" + fix quitting RetroArch from arcade games Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New or improved feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants