Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "Features" page #1578

Merged
merged 4 commits into from
May 21, 2024
Merged

Update "Features" page #1578

merged 4 commits into from
May 21, 2024

Conversation

ikem-krueger
Copy link
Contributor

No description provided.

@Aemiii91
Copy link
Member

Aemiii91 commented May 7, 2024

Not sure I'm a fan of the backticks 🤔

@ikem-krueger
Copy link
Contributor Author

I tried to be consistent here.

@Aemiii91
Copy link
Member

Aemiii91 commented May 8, 2024 •
edited
Loading

Ah, I see, we are a bit inconsistent! How about we use bold for names? I would prefer to use backticks/code only for user input and such.

@ikem-krueger
Copy link
Contributor Author

I think that should be fine.

Aemiii91
Aemiii91 requested changes May 9, 2024
View reviewed changes
Copy link
Member

@Aemiii91 Aemiii91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the formatting of names to bold instead of code.

Note: code formatting should be reserved for user input and alike.

@ikem-krueger
Copy link
Contributor Author

I changed the formatting to bold.

Aemiii91
Aemiii91 requested changes May 20, 2024
View reviewed changes
Copy link
Member

@Aemiii91 Aemiii91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good! Just had that one minor detail - then it's perfect 😁👌

website/docs/01-features/index.md Outdated Show resolved Hide resolved
@ikem-krueger
Copy link
Contributor Author

Fixed it.

@Aemiii91 Aemiii91 enabled auto-merge May 21, 2024 20:48
@Aemiii91 Aemiii91 added this pull request to the merge queue May 21, 2024
Merged via the queue into OnionUI:main with commit 26e1207 May 21, 2024
2 checks passed
@Aemiii91 Aemiii91 added the documentation Improvements or additions to documentation label May 21, 2024
@Aemiii91 Aemiii91 changed the title Update index.md Update "Features" page May 21, 2024
@Aemiii91
Copy link
Member

Thank you 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aemiii91 Aemiii91 Aemiii91 approved these changes

Assignees

@ikem-krueger ikem-krueger

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikem-krueger @Aemiii91