-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 752x560 resolution used by new MMv4 screens #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to inform them of resolution change from runtime.sh needed for low battery icon and brightness OSD bar
Add blacklist for games/apps that don't support 752x560
move get_screen_resolution further back in the init function
Add blanket exception for games Ignore newlines and comments in res_exceptions
schmurtzm
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome feature for v4 users !
I would prefer to invert the compatibility list : a whitelist of all the apps compatible with 560p but given that it is technically complex to set up and the fact that compatibility seems excellent, it will do the trick 👍🏻.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for 752x560 resolution.
On startup, runtime checks the physical screen resolution and stores it to
/tmp/screen_resolution
If the firmware is 202310271401 and the physical resolution is 752x560, it also creates the flag
/tmp/new_res_available
If this flag is set on game launch, the resolution is changed and keymon and batmon are informed of this via signal so they can update their stored resolutions.
Keymon was updated to respect the render resolution when drawing the brightness bar, batmon was updated to respect the render resolution when drawing the "battery empty" icon.
TODO:
implement either a blacklist for anything hardcoded to 640x480 or a whitelist for anything that supports 752x560?
so far only drastic is added as exception.
testing, finding edge cases, other resolution dependent things?
overlays