Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Add backoff to OperationRepo when retrying network calls #2017

Merged
merged 1 commit into from
Mar 7, 2024

Commits on Mar 5, 2024

  1. add backoff to operations when retrying

    If we got a 5xx response from the OneSignal backend we were retrying
    immediately. This result wasn't positive for the end-user, device,
    or OneSignal's backend.
    
    To ensure this works as expected we updated the retrying test to
    confirm the delay is called.
    
    Also to ensure this commit works as intended I ran this on an Android 14
    emu and ensured it waits the right amount of time when there is 500
    response. Also after we stop getting a 500 error the queue successfully
    resumes and all pending tags are even added too.
    jkasten2 committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    591098c View commit details
    Browse the repository at this point in the history