This repository has been archived by the owner on Jan 29, 2023. It is now read-only.
Support specified wallet to get balance information #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuaiLiWang
changed the title
shuaiLiWang
force-pushed
the
add_id_for_get_balance
branch
from
9b8dbcc to
f7e4df0
Compare
shuaiLiWang
force-pushed
the
add_id_for_get_balance
branch
from
f7e4df0 to
ed4e5ba
Compare
shuaiLiWang
changed the title
taimanhui
reviewed
Jun 23, 2021
| @@ -925,9 +925,9 @@ def get_coins(self, coins_info): | |||
| coins.append(utxo) | |||
| return coins | |||
|
|
|||
| def format_return_data(self, feerate, size, block): | |||
| def format_return_data(self, feerate, size, block, coin): | |||
| @@ -960,7 +960,9 @@ def get_default_fee_info(self, feerate=None, coin="btc", eth_tx_info=None): | |||
| "normal": {"gas_price": 79, "time": 3, "gas_limit": 40000, "fee": "0.00316", "fiat": "4.33 USD"}, | |||
| "slow": {"gas_price": 72, "time": 10, "gas_limit": 40000, "fee": "0.00288", "fiat": "3.95 USD"}} | |||
| """ | |||
| self._assert_wallet_isvalid() | |||
|
|
|||
| wallet = self.get_wallet_by_name(id) if id else self.wallet | |||
There was a problem hiding this comment.
不太合理，把id作为一个必须的属性，然后去掉self.wallet会更好点，就是直接抛弃self.wallet了。那么get_wallet_by_name里找不到wallet的话可以抛出找不到钱包的统一异常
| @@ -1122,6 +1127,8 @@ def get_fee_by_feerate(self, coin="btc", outputs=None, message=None, feerate=Non | |||
| else if coin is "eth": | |||
| json like {"gas_price": 110, "time": 0.25, "gas_limit": 36015, "fee": "0.00396165", "fiat": "5.43 USD"} | |||
| """ | |||
| wallet = self.get_wallet_by_name(id) if id else self.wallet | |||
| """ | ||
| Confirm to create transaction, for btc only | ||
| :param tx: tx that created by get_fee_by_feerate | ||
| :return: json like {"tx":""} | ||
| """ | ||
|
|
||
| try: | ||
| self._assert_wallet_isvalid() | ||
| wallet = self.get_wallet_by_name(id) if id else self.wallet |
现在的新页面设计是需要的 总资产里边点进去需要支持直接转账 并且回到钱包页面的时候 不能切换钱包 |
|
上周最后的结论是隐藏掉所有资产页面进去之后的转账功能，等我们解耦之后才来处理，所以这个留着或者关掉都可以，做个记录 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
commit1：get_wallet_balance支持指定钱包获取余额
commit2：转账相关接口支持指定钱包操作
Does this close any currently open issues?
If it fixes a bug or resolves a feature request, be sure to link to that issue.
…
Pull request type
Put an
xin the boxes that applyWhere has this been tested?
…
Any other comments?
…