fix(atoms): disable ecosystem.find() fuzzy search if params are passed
#103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The recent change to add fuzzy search to
ecosystem.find()(#79) made the search too fuzzy. Specifically, when atom params are passed to `ecosystem.find() , it's never expected that anything but an exact match is returned. Disable fuzzy search when params are passed.I'm categorizing this as a bug fix, since the overtly-fuzzy search wasn't expected behavior. But it's also a new feature - e.g. now when passing a search string as the first param, you can pass an empty array as the second param to only return an exact match (or undefined if no match).