Added toggle option for project.json warning #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* moved local functions moved local functions to top for readability and fixed missing semicolon local function at the end tslint exception for chai * use genral tslint chai rules * fix path to custom chai rules * revert type package versions * simplify gulp file * force chai types to 4.0.8
This reverts commit 894b0ca. update version
rchande
approved these changes
Dec 18, 2017
DustinCampbell
approved these changes
Dec 18, 2017
package.json
Outdated
| @@ -335,6 +335,11 @@ | |||
| "default": false, | |||
| "description": "Suppress the notification window to perform a 'dotnet restore' when dependencies can't be resolved." | |||
| }, | |||
| "csharp.suppressProjectDotJsonWarning": { | |||
There was a problem hiding this comment.
Probably don't need the 'Dot' in the option name.
|
Can you merge my pull request?
…On 18 December 2017 at 18:25:31, akshita31 ***@***.******@***.***)) wrote:
Merged #1926(#1926).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub(#1926 (comment)), or mute the thread(https://github.com/notifications/unsubscribe-auth/AAW7BFmWn3UeJCWqyG1xX30NSx2c87DFks5tBq4bgaJpZM4REIv9).
|
|
Which one ? |
|
I did merge it, thank you.
…On 18 December 2017 at 18:42:50, akshita31 ***@***.******@***.***)) wrote:
Which one ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub(#1926 (comment)), or mute the thread(https://github.com/notifications/unsubscribe-auth/AAW7BPug5PYsyMS8yEhiq5KlAZE3v_ecks5tBrIqgaJpZM4REIv9).
|
|
👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : #1920
Added a suppressProjectDotJsonWarning toggle option and modified the code to check for the same.