Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger completion on space if object creation completion is available #975

Merged
merged 1 commit into from
Oct 5, 2017
Merged

Trigger completion on space if object creation completion is available #975

merged 1 commit into from
Oct 5, 2017

Conversation

rchande
Copy link

@rchande rchande commented Oct 4, 2017

...if object creation completion is available. Currently does not
attempt to implement any preselection-like experience.

Depends on dotnet/vscode-csharp#1776

Trigger completion on space...
574aabb 
...if object creation completion is available. Currently does not
attempt to implement any preselection-like experience.
@rchande
Copy link
Author

rchande commented Oct 4, 2017

Tag @DustinCampbell -- for some reason the "reviewers" UI won't let me add you that way.

@DustinCampbell DustinCampbell self-requested a review October 4, 2017 22:33
@DustinCampbell DustinCampbell changed the title Trigger completion on space... Trigger completion on space if object creation completion is available Oct 4, 2017
@DustinCampbell
Copy link
Contributor

Tag @DustinCampbell -- for some reason the "reviewers" UI won't let me add you that way.

You're only officially a member of the omnisharp-vscode team.

DustinCampbell
DustinCampbell approved these changes Oct 4, 2017
View reviewed changes
Copy link
Contributor

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Hopefully, we can get rid of the reflection ugliness if I ever get back to #884

@rchande
Copy link
Author

rchande commented Oct 4, 2017

@DustinCampbell What's left in #884? Is it something I could help finish up for you?

@rchande
Copy link
Author

rchande commented Oct 4, 2017

Also cc @piotrpMSFT and @jonsequitur in case they're interested.

@DustinCampbell
Copy link
Contributor

There's not much left in #884. I ran into some workspace issues where tracking document open/close states became necessary due to a bug in Roslyn's AbstractMemberInsertingCompletionProvider that I fixed here. I got side-tracked while making the open/close states work though.

david-driscoll
david-driscoll approved these changes Oct 5, 2017
View reviewed changes
Copy link
Member

@david-driscoll david-driscoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@david-driscoll
Copy link
Member

Kicked travis... the mac build failed for some reason.

filipw
filipw approved these changes Oct 5, 2017
View reviewed changes
Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DustinCampbell DustinCampbell merged commit 6b90582 into OmniSharp:master Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipw filipw filipw approved these changes

@david-driscoll david-driscoll david-driscoll approved these changes

@DustinCampbell DustinCampbell DustinCampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rchande @DustinCampbell @david-driscoll @filipw