Cake support #932
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| using System.Runtime.CompilerServices; | ||
|
|
||
| [assembly: InternalsVisibleTo("OmniSharp.Cake.Tests")] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| using System.Collections.Generic; | ||
| using System.Collections.Immutable; | ||
| using Microsoft.CodeAnalysis; | ||
| using Microsoft.CodeAnalysis.Scripting; | ||
|
|
||
| namespace OmniSharp.Cake | ||
| { | ||
| internal class CachingScriptMetadataResolver : MetadataReferenceResolver | ||
| { | ||
| private static readonly Dictionary<string, ImmutableArray<PortableExecutableReference>> DirectReferenceCache = new Dictionary<string, ImmutableArray<PortableExecutableReference>>(); | ||
| private static readonly Dictionary<string, PortableExecutableReference> MissingReferenceCache = new Dictionary<string, PortableExecutableReference>(); | ||
| private static readonly MetadataReferenceResolver DefaultRuntimeResolver = ScriptMetadataResolver.Default; | ||
|
|
||
| public override bool Equals(object other) | ||
| { | ||
| return DefaultRuntimeResolver.Equals(other); | ||
| } | ||
|
|
||
| public override int GetHashCode() | ||
| { | ||
| return DefaultRuntimeResolver.GetHashCode(); | ||
| } | ||
|
|
||
| public override bool ResolveMissingAssemblies => DefaultRuntimeResolver.ResolveMissingAssemblies; | ||
|
|
||
| public override PortableExecutableReference ResolveMissingAssembly(MetadataReference definition, AssemblyIdentity referenceIdentity) | ||
| { | ||
| if (MissingReferenceCache.TryGetValue(referenceIdentity.Name, out var result)) | ||
| { | ||
| return result; | ||
| } | ||
|
There was a problem hiding this comment. minor nit: Could this use |
||
|
|
||
| result = DefaultRuntimeResolver.ResolveMissingAssembly(definition, referenceIdentity); | ||
| if (result != null) | ||
| { | ||
| MissingReferenceCache[referenceIdentity.Name] = result; | ||
| } | ||
|
|
||
| return result; | ||
| } | ||
|
|
||
| public override ImmutableArray<PortableExecutableReference> ResolveReference(string reference, string baseFilePath, MetadataReferenceProperties properties) | ||
| { | ||
| var key = $"{reference}-{baseFilePath}"; | ||
| if (DirectReferenceCache.TryGetValue(key, out var result)) | ||
| { | ||
| return result; | ||
| } | ||
|
There was a problem hiding this comment. minor nit: Could this use |
||
|
|
||
| result = DefaultRuntimeResolver.ResolveReference(reference, baseFilePath, properties); | ||
| if (result.Length > 0) | ||
| { | ||
| DirectReferenceCache[key] = result; | ||
| } | ||
|
|
||
| return result; | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| namespace OmniSharp.Cake | ||
| { | ||
| internal class CakeContextModel | ||
| { | ||
| public CakeContextModel(string filePath) | ||
| { | ||
| Path = filePath; | ||
| } | ||
|
|
||
| public string Path { get; } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| using System.Collections.Generic; | ||
|
|
||
| namespace OmniSharp.Cake | ||
| { | ||
| internal class CakeContextModelCollection | ||
| { | ||
| public CakeContextModelCollection(IEnumerable<CakeContextModel> projects) | ||
| { | ||
| Projects = projects; | ||
| } | ||
|
|
||
| public IEnumerable<CakeContextModel> Projects { get; } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should either of these caches be case-insensitive on the key?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dunno, this was copy-pasted-with-pride from what used to be in OmniSharp.Script. Let’s ask @filipw?