Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect "nowarn" setting in dotnet project system #734

Merged
merged 3 commits into from
Jan 27, 2017

Conversation

filipw
Copy link
Member

@filipw filipw commented Jan 27, 2017

Fixes dotnet/vscode-csharp#542

At the moment we completely ignored the user defined suppressions.

Copy link
Contributor

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filipw filipw force-pushed the bugfix/vscode-542 branch from 9c2838f to cd479db Compare January 27, 2017 19:52
@kirkone
Copy link

kirkone commented Mar 8, 2017

I have no clue why but this is not working with *.csproj based projects anymore.

when I run "dotnet build" I get no warnings but VSCode goes crazy with warnings at the same time.
Any idea what I am doing wrong?

Greetings,
KirK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants