Editorconfig improvements - do not lose state, trigger re-analysis on change #2028
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompilationOptions
based on the csproj file when a project update is triggered (e.g. rebuild, change in csproj). This causes us to lose the editorconfig state because it is kept inSyntaxTreeOptionsProvider
which gets reset then. The PR ensures the new compilation options are created only when necessary, and also derived from the previous ones.AnalyzerConfigDocumentChanged
) which is now newly handled to trigger re-analysis.