Added support for decompilation based on ILSpy (similar to VS) #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EditorFeatures package
bjorkstromm
reviewed
Apr 3, 2020
src/OmniSharp.Roslyn.CSharp/Services/ExternalSourceServiceFactory.cs
Outdated
Show resolved
Hide resolved
src/OmniSharp.Roslyn.CSharp/Services/ExternalSourceServiceFactory.cs
Outdated
Show resolved
Hide resolved
david-driscoll
approved these changes
Apr 7, 2020
baronfel
reviewed
Apr 9, 2020
src/OmniSharp.Roslyn.CSharp/Services/Decompilation/OmniSharpCSharpDecompiledSourceService.cs
Show resolved
Hide resolved
JoeRobich
approved these changes
Apr 9, 2020
src/OmniSharp.Roslyn.CSharp/Services/ExternalFeaturesHostServicesProvider.cs
Outdated
Show resolved
Hide resolved
src/OmniSharp.Roslyn.CSharp/Services/Decompilation/OmniSharpCSharpDecompiledSourceService.cs
Outdated
Show resolved
Hide resolved
…harpDecompiledSourceService.cs Co-Authored-By: Joey Robichaud <jorobich@microsoft.com>
…cesProvider.cs Co-Authored-By: Joey Robichaud <jorobich@microsoft.com>
|
ok, approved then I'm merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implemented as a variation on the /gotodefinition and /metadata endpoints.
Setting the flag
RoslynExtensionsOptions:EnableDecompilationSupporttotruemeans the user opts into decompilation instead of metadata.The changeset is relatively big because I needed to refactor the existing metadata service and then matched the new decompilation logic to it, this way metadata services and decompilation are fully interchangeable.
No client changes needed and you can navigate from decompiled code to another symbol that needs to be decompiled (just like we support in metadata at the moment)
preview: http://g.recordit.co/9XaNkEE4lt.gif