Update Roslyn build

[rchande]

No description provided.

[filipw]

The test failures are real.

[filipw]

Looks like the root cause is that Symbols and Provider properties are no longer available on the CompletionItem. We used them to find/decode matching symbols here

omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Services/Intellisense/CompletionItemExtensions.cs

Lines 42 to 64 in 6836fad

	public static async Task<IEnumerable<ISymbol>> GetCompletionSymbolsAsync(this CompletionItem completionItem, IEnumerable<ISymbol> recommendedSymbols, Document document)
	{
	var properties = completionItem.Properties;
	// for SymbolCompletionProvider, use the logic of extracting information from recommended symbols
	if (properties.TryGetValue(Provider, out var provider) && provider == SymbolCompletionProvider)
	{
	return recommendedSymbols.Where(x => x.Name == properties[SymbolName] && (int)x.Kind == int.Parse(properties[SymbolKind])).Distinct();
	}
	// if the completion provider encoded symbols into Properties, we can return them
	if (properties.ContainsKey(Symbols))
	{
	// the API to decode symbols is not public at the moment
	// http://source.roslyn.io/#Microsoft.CodeAnalysis.Features/Completion/Providers/SymbolCompletionItem.cs,93
	var decodedSymbolsTask = _getSymbolsAsync.InvokeStatic<Task<ImmutableArray<ISymbol>>>(new object[] { completionItem, document, default(CancellationToken) });
	if (decodedSymbolsTask != null)
	{
	return await decodedSymbolsTask;
	}
	}
	return Enumerable.Empty<ISymbol>();

[rchande]

Looking...

[filipw]

I thought most (all?) completion items will be created via CreateWithSymbolId? Roslyn doesn't encode the symbol into the completion item anymore?

but if that's the case, we can make this return the same as above - return recommendedSymbols.Where(x => x.Name == properties[SymbolName] && (int)x.Kind == int.Parse(properties[SymbolKind])).Distinct();

[filipw]

I'm a bit worried that we might lose some feature by not decoding the symbol from the completion item but looks like we have tests for most of the more esoteric cases (cref completion, named parameter completion, attribute without suffix completion etc) so LGTM 👍

[SteamUpdate]

I read changelog and saw that line

[SteamUpdate]

properties.ContainsKey(SymbolName) - why this code is duplicated? Maybe second check must be properties.ContainsKey(SymbolKind) ?

[filipw]

yes, it's a typo thanks for finding this 👍I opened the fix here #1491