Fix missing signatures for some cases #1290
Conversation
There was a problem hiding this comment.
since Roslyn 2.9.0, Quick Info API is there dotnet/roslyn#20554
@filipw: yeah, I've been meaning to go and use that in OmniSharp. Still trying to find time to make a public Signature Help API. |
|
@SirIntruder: A public signature help API for Roslyn is on my plate: dotnet/roslyn#3540 |
| } | ||
| }"; | ||
| var actual = await GetSignatureHelp(filename, source); | ||
| Assert.NotEmpty(actual.Signatures); |
There was a problem hiding this comment.
It would be great if this could also assert that one of the intended signatures exists.
| } | ||
| }"; | ||
| var actual = await GetSignatureHelp(filename, source); | ||
| Assert.NotEmpty(actual.Signatures); |
There was a problem hiding this comment.
It would be great if this could also assert that one of the intended signatures exists.
There was a problem hiding this comment.
This way we can avoid potential signatures being removed when they shouldn't have been.
|
@david-driscoll New enhanced assert now checks if signature list contains one known valid signature (right name, zero parameters). Would this be enough? |
filipw
dismissed
david-driscoll’s stale review
the requested change was implemented
A fix for dotnet/vscode-csharp#2495. Provides missing signature help for compiler literals and typeof(T)... expressions. Added two tests for those cases.
bonus question: will roslyn cover the whole signature service soon? it sounds like something that should be handled out-of-the-box