ArgumentOutOfRangeException from completion/resolve on the 1st line of top level program

[filipw]

This reproduces for me with an empty .cs file + a regular project file, when trying to use the top level statements.

As I start typing Console I see the following in the logs (using OmniSharp 1.37.6):

[warn]: OmniSharp.Stdio.Host
        ************ Request ************
{
  "Type": "request",
  "Seq": 581,
  "Command": "/completion/resolve",
  "Arguments": {
    "Item": {
      "Label": "Console",
      "Kind": 7,
      "Tags": null,
      "Detail": "System",
      "Documentation": null,
      "Preselect": false,
      "SortText": "1Console System",
      "FilterText": "Console",
      "InsertTextFormat": 1,
      "TextEdit": {
        "NewText": "Console",
        "StartLine": 0,
        "StartColumn": 0,
        "EndLine": 0,
        "EndColumn": 1
      },
      "CommitCharacters": [
        " ",
        "{",
        "}",
        "[",
        "]",
        "(",
        ")",
        ".",
        ",",
        ":",
        ";",
        "+",
        "-",
        "*",
        "/",
        "%",
        "&",
        "|",
        "^",
        "!",
        "~",
        "=",
        "<",
        ">",
        "?",
        "@",
        "#",
        "'",
        "\"",
        "\\"
      ],
      "AdditionalTextEdits": null,
      "Data": 455
    }
  }
}
[fail]: OmniSharp.Stdio.Host
        ************  Response ************ 
{
  "Request_seq": 581,
  "Command": "/completion/resolve",
  "Running": true,
  "Success": false,
  "Message": "\"System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values.\\nParameter name: position\\n  at Microsoft.CodeAnalysis.Text.SourceText+LineInfo.IndexOf (System.Int32 position) [0x00012] in <02f1a35137194cc3b7bab26f0cb540aa>:0 \\n  at Microsoft.CodeAnalysis.Text.SourceText+LineInfo.GetLineFromPosition (System.Int32 position) [0x00000] in <02f1a35137194cc3b7bab26f0cb540aa>:0 \\n  at Microsoft.CodeAnalysis.Text.TextLineCollection.GetLinePosition (System.Int32 position) [0x00000] in <02f1a35137194cc3b7bab26f0cb540aa>:0 \\n  at OmniSharp.Roslyn.CSharp.Services.Completion.CompletionService.GetAdditionalTextEdits (Microsoft.CodeAnalysis.Completion.CompletionChange change, Microsoft.CodeAnalysis.Text.SourceText sourceText, Microsoft.CodeAnalysis.CSharp.CSharpParseOptions parseOptions, Microsoft.CodeAnalysis.Text.TextSpan typedSpan, System.String completionDisplayText, System.String providerName) [0x00030] in <c8591cb9164d4c0c9d9cc0ca8a5741e8>:0 \\n  at OmniSharp.Roslyn.CSharp.Services.Completion.CompletionService.Handle (OmniSharp.Models.v1.Completion.CompletionResolveRequest request) [0x004c3] in <c8591cb9164d4c0c9d9cc0ca8a5741e8>:0 \\n  at OmniSharp.Endpoint.EndpointHandler`2[TRequest,TResponse].GetFirstNotEmptyResponseFromHandlers (OmniSharp.Endpoint.Exports.ExportHandler`2[TRequest,TResponse][] handlers, TRequest request) [0x00099] in <f1c1a4d731e249dab8abb3b16a7202fe>:0 \\n  at OmniSharp.Endpoint.EndpointHandler`2[TRequest,TResponse].HandleRequestForLanguage (System.String language, TRequest request, OmniSharp.Protocol.RequestPacket packet) [0x00163] in <f1c1a4d731e249dab8abb3b16a7202fe>:0 \\n  at OmniSharp.Endpoint.EndpointHandler`2[TRequest,TResponse].Process (OmniSharp.Protocol.RequestPacket packet, OmniSharp.Endpoint.LanguageModel model, Newtonsoft.Json.Linq.JToken requestObject) [0x002d8] in <f1c1a4d731e249dab8abb3b16a7202fe>:0 \\n  at OmniSharp.Stdio.Host.HandleRequest (System.String json, Microsoft.Extensions.Logging.ILogger logger) [0x000e8] in <438371f941214689ad1ed79c148e9213>:0 \"",
  "Body": null,
  "Seq": 470,
  "Type": "response"
}

The completion works but because resolve doesn't work, the details are empty:

This doesn't happen on line 2 anymore:

[filipw]

looks like it's happening here

omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Services/Completion/CompletionService.cs

Line 524 in 63834ec

var additionalEditEndPosition = sourceText.Lines.GetLinePosition(typedSpan.Start - 1);

and it ends up being -1 since we are on line 0.

@333fred do you remember, is this subtraction intentional? I thought we are now on zero based indices

[333fred]

@333fred do you remember, is this subtraction intentional? I thought we are now on zero based indices

Yes, it was intentional. This is because we don't want the current cursor location to intersect with the additional text edit. I'm not entirely sure whether we can make it just work without the -1, it'll need to be tested in vscode to make sure it doesn't get overwritten.