Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start OmniSharp from dotnet cli #317

Closed
wants to merge 1 commit into from
Closed

start OmniSharp from dotnet cli #317

wants to merge 1 commit into from

Conversation

w9n
Copy link

@w9n w9n commented Jun 19, 2017

from my knowledge one can only start dotnetcore apps from the dotnet cli(in linux). it works in spacemacs with dotnet-path set to /usr/bin/dotnet and omnisharp-server-executable-path to ...OmniSharp.dll - This start-process parameter breaks Mono compability

from my knowledge one can only start dotnetcore apps from the dotnet cli. it works in spacemacs with dotnet-path set to /usr/bin/dotnet and omnisharp-server-executable-path to ...OmniSharp.dll
@razzmatazz
Copy link
Contributor

I would be hesistant to merge this PR because:

  • This would break existing installations
  • omnisharp-roslyn (at least on macOS) has wrapper scripts to run mono with OmniSharp.exe on unix platforms
  • on Windows there is no need to wrap .exe (unless you want to run them in mono, I guess)

Recent omnisharp-roslyn versions are to be used with mono runtime and the project is considering integrating mono runtime itself with the distribution.

Could you describe a situation where your PR is making omnisharp-emacs to work?

@razzmatazz
Copy link
Contributor

Also, please see this issue: #275 where there are plans to get rid of manual configuration and do automatic installation of omnisharp server instead. Any help would be greatly anticipated

@w9n w9n closed this Jun 28, 2017
@w9n w9n deleted the patch-1 branch June 28, 2017 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants