Support flycheck in csharp-mode

[dtebbs]

This could be an issue with my setup, but after upgrading to the latest version I couldn't get flycheck to run.

I seem to havecsharp-mode as my major-mode, whereas csharp-omnisharp-codecheck expects omnisharp-mode. I had to make this change to get things to work.

I'm no expert with this stuff, so happy to believe this is a problem with my .emacs file.
Currently I have:

(if (require 'omnisharp nil 'noerror)
    (progn
      (require 'company)
      (setq omnisharp--curl-executable-path "~/emacs-env/curl.exe")
      (setq omnisharp-server-executable-path "~/emacs-env/omnisharp-server/OmniSharp/bin/Release/OmniSharp.exe")
      (push 'company-omnisharp company-backends)
      (add-hook 'csharp-mode-hook 'company-mode)
      (add-hook 'csharp-mode-hook 'omnisharp-mode)
      (define-key omnisharp-mode-map (kbd "M-.") 'omnisharp-go-to-definition)
      )
  )

Should I see omnisharp-mode as the major-mode? If so, what am I doing wrong?

Thanks in advance for any help.

[hypercross]

+1 This also happens to me on my spacemacs

[waldnercharles]

+1 This is happening with me as well.

[ngscheurich]

I'm similarly baffled, @dtebbs—it is my naive understanding that Flycheck checks against the current major mode, and that omnisharp-mode is exclusively a minor mode. I'm hoping someone will shed some light on this soon, but for now I've implemented a non-destructive change on my machine, i.e.:

:modes (omnisharp-mode csharp-mode)

Just in case.

[razzmatazz]

@hypercross @waldnercharles @dtebbs

Sorry for getting to this issue so late, but can I ask any you to confirm if this issue persists on the omnisharp-roslyn branch too (https://github.com/OmniSharp/omnisharp-emacs/tree/feature-omnisharp-roslyn-support)?

As personally I have not encountered this on the roslyn branch, which is due to be released soon as master.

[dtebbs]

I haven't run against the omnisharp-roslyn branch, but I can see that the :modes line only refers to csharp-mode (like my patch above), and not omnisharp-mode. So it would seem this problem does not exist in omnisharp-roslyn.

[razzmatazz]

@dtebbs – I am closing this PR now then as the original omnisharp-emacs code is now on legacy branch