Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styling paradigm v2 #13

Merged
merged 30 commits into from
Mar 12, 2023
Merged

styling paradigm v2 #13

merged 30 commits into from
Mar 12, 2023

Conversation

Omikhleia
Copy link
Owner

@Omikhleia Omikhleia commented Feb 18, 2023

Closes #12

@Omikhleia Omikhleia marked this pull request as draft February 18, 2023 14:56
@Omikhleia Omikhleia force-pushed the new-styling-paradigm branch 4 times, most recently from a5e2e4e to c149ff4 Compare February 19, 2023 20:30
@Omikhleia Omikhleia self-assigned this Feb 21, 2023
@Omikhleia Omikhleia added this to the 2.0 milestone Feb 21, 2023
@Omikhleia Omikhleia added the enhancement New feature or request label Feb 21, 2023
@Omikhleia Omikhleia force-pushed the new-styling-paradigm branch 2 times, most recently from f9db1ba to 1973d09 Compare February 27, 2023 19:31
@Omikhleia Omikhleia marked this pull request as ready for review March 4, 2023 00:58
@Omikhleia Omikhleia mentioned this pull request Mar 10, 2023
4 tasks
Easier maintenance, I'm losing my mind in the current file.
This size=+1 or size=-0.5 etc. idea was plain wrong in the first
place. We need em-relative sizes for the more general case.
And refactor some doc chapters in separate folders, because
I am getting lost. More structure, cleaner maintenance!
Includes the docs update, as there was no obvious way to split
it and keep it working independently.
Breaking in the sense that it impacts how previous documents
appeared by default (esp. due to shaper.spaceenlargementfactor)
but the SILE defaults are utterly incorrect.
Too many information that most users do not need, it's a bit
distracting and not worth the point yet.
Ah. Found at last, tricky problem when some paragraph styles
were applied and the footnotes from them had weird indents!
- Common code extracted to resilient.utils
- Some SILE hacks extracted to resilient.hacks
See lua-libraries/README.tinyyaml for reasons to vendor it and
rename its source file.
@Omikhleia Omikhleia merged commit 0f61ff0 into main Mar 12, 2023
@Omikhleia Omikhleia deleted the new-styling-paradigm branch April 10, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switching to the new style paradigm API (breaking)
2 participants