-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server rendering to improve load time performance #1
Open
OliverJAsh
wants to merge
48
commits into
master
Choose a base branch
from
server-side-rendering
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stale-while-revalidate is a broken model when the JS is separate.
Remove from shell
OliverJAsh
changed the title
Shared rendering to improve load time performance
Server rendering to improve load time performance
Sep 27, 2015
OliverJAsh
force-pushed
the
server-side-rendering
branch
from
September 27, 2015 22:18
f952c56
to
224593d
Compare
TODO: Use content negotiation |
OliverJAsh
force-pushed
the
server-side-rendering
branch
from
November 22, 2015 07:52
7a8def2
to
68af1bf
Compare
OliverJAsh
force-pushed
the
server-side-rendering
branch
from
November 22, 2015 08:26
68af1bf
to
0ed48bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://simple-offline-blog.herokuapp.com/
For these users:
… rendering on the server will improve load times, because the content is in the very first request for the HTML. No further network requests nor JS execution needed.
I took the shared rendering approach for its nice developer ergonomics. Server renders the core content, client re-renders to enhance the content, all using the same template code.
Here is the updated architecture blob:
share the same template (aka isomorphism or shared rendering).
will be proxied by the ServiceWorker, which will respond with a cached shell
(a wrapper for the content). The shell contains JavaScript which is
responsible for fetching and rendering content.
Note that this means browsers without ServiceWorker support will just continue
to use server side rendering.