Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Always flush in NativeAnimatedTurboModule
Summary: ## Summary In the past, NativeAnimatedModule could animate **both** Paper **and** Fabric components. For Fabric nodes, we needed to manually flush NativeAnimatedModule's operations queue. So, we started tracking which nodes were Fabric owned in NativeAnimatedModule. ## Changes With bridgeless mode, all components must be Fabric-owned. So, should be able to remove this fabric ownership tracking logic and **always flush.** ## Is this safe? In the worst case, we over-flush. This doesn't seem bad. cc sammy-SC. ## Do we still need flushing? Arguably, all this manual flushing should be unnecessary, because we already migrated AnimatedModule's Paper integration to RCTSurfacePresenterObserver, here: D14336760 (facebook@544d9fb). So, do we still need this flushing? Yes. Here's what happens when you disable all the manual flushing in bridgeless mode: https://pxl.cl/2dqPf. Long-term, we need to re-think this operations queuing in NativeAnimatedTurboModule. I left my thoughts in T130668424 (Investigation - Day 5). Changelog: [Internal] Reviewed By: p-sun Differential Revision: D39592477 fbshipit-source-id: e971edc0d99661a37b5f430bce46c78acaa121c0
- Loading branch information