Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child process exec options, fixes maxBuffer size problem #8

Merged
merged 5 commits into from
Jul 12, 2019
Merged

Child process exec options, fixes maxBuffer size problem #8

merged 5 commits into from
Jul 12, 2019

Conversation

yunusga
Copy link
Contributor

@yunusga yunusga commented Jul 12, 2019

This PR closes #3 and closes #7.

Increase maxBuffer size to prevent #3, !!! OUTPUT ERROR or Unexpected end of JSON input errors. This is because child_process stdout being truncated when validator check a lot of files.

Version maxBuffer Documentation link
8.x LTS 200 * 1024 child_process.exec(command[, options][, callback])
10.x LTS 200 * 1024 child_process.exec(command[, options][, callback])
12.x 1024 * 1024 child_process.exec(command[, options][, callback])

@yunusga yunusga changed the title Child process exec options Child process exec options, fixes maxBuffer size problem Jul 12, 2019
@OlehDutchenko
Copy link
Owner

@yunusga thx a lot!

@OlehDutchenko OlehDutchenko merged commit 35d23b3 into OlehDutchenko:master Jul 12, 2019
@yunusga yunusga deleted the child_process_exec_options branch July 12, 2019 10:12
@OlehDutchenko
Copy link
Owner

@yunusga - I'am just already updated new version at npm - 1.3.0,
and my thanks in readme.md https://github.com/dutchenkoOleg/node-w3c-validator#contributors-

@yunusga
Copy link
Contributor Author

yunusga commented Jul 12, 2019

@dutchenkoOleg, cool 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node sdout buffer size limits (stdout being truncated) Running node-w3c-validator throw error
2 participants