Improve compatibility in complex cross-targeting scenarios. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for a dll compiled against netstandard2.0 with this as a depedency to be consumed from another dll compiled against net6.0 (or greater) without requiring the netstandard2.0 dll to multitarget netstandard2.0 and net6.0. This is achieved by the removal of the conditional remove of the output dlls in the package, instead opting for conditional exclusion of most of the codebase except for three [assembly: TypeForwardedTo()] declarations which allow the compiler and runtimes to swap out the type decalrations here for the real ones in net6.0.
|
@Chryssie thanks a lot for this PR and your help. I've spent some time trying to understand/reproduce the original problem with transitive dependency and now I know the root cause better. Proposed changes solve this problem, but I have some ideas to improve it. We have two options:
Please, tell me which option works better for you and I'll process with the next step. |
3 tasks
|
@OlegRa I've enabled edits by maintainers so you should be able to make your changes now. |
…impler: - Generate reference-only assemblies and place these assemblies into the `ref` folder in NuGet package - Include/exclude files from TFM-specific builds using project file instead of conditional compilation - Revet back .NET 6.0 TFM `lib` folder empty placeholder for preventing unused assembly copy
|
@all-contributors please add @Chryssie for code. |
|
I've put up a pull request to add @Chryssie! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for a dll compiled against netstandard2.0 with this as a depedency to be consumed from another dll compiled against net6.0 (or greater) without requiring the netstandard2.0 dll to multitarget netstandard2.0 and net6.0.
This is achieved by the removal of the conditional remove of the output dlls in the package, instead opting for conditional exclusion of most of the codebase except for three
[assembly: TypeForwardedTo()]declarations which allow the compiler and runtimes to swap out the type decalrations here for the real ones in net6.0.