Remove shared-web #1374
Merged
Remove shared-web #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorek
requested review from
baphled,
frankieroberto,
slawosz and
StupidCodeFactory
|
Liking this a lot... 😄 |
slorek
force-pushed
the
remove_from_shared_web
branch
2 times, most recently
from
fee88b6 to
824b7c0
Compare
slorek
changed the title
slorek
changed the title
frankieroberto
approved these changes
Oct 11, 2019
…ies are now specified
…n is not used in the cosmetics-web application, so it was removed
…red-web code into main applciation
slorek
force-pushed
the
remove_from_shared_web
branch
from
fba5566 to
99ad584
Compare
frankieroberto
pushed a commit
that referenced
this pull request
Oct 18, 2019
* Redirect the user to Additional Information when the user has uploaded a (#1377) bulk files and has completed the nanomaterial section * Remove shared-web (#1374) * Move Coveralls rake task to main application, and delete redundant monkey patch * Move Webpacker Rake tasks to main application * Move application dependencies to main application * Move initializers from shared-web to main application where dependencies are now specified * Move shared-web models to main application. It appears the DateConcern is not used in the cosmetics-web application, so it was removed * Remove redundant jobs folder from shared-web * Move anti-virus analyzer classes from shared-web to main application * Move KeycloakClient from shared-web to main application * Remove redundant mailers from shared-web * Move helpers from shared-web to main application * Fix KeycloakCheck load order * Move controllers and concerns from shared-web to main application * Move ElasticSearch dependency to main application * Fix session path * Update Gemfile.lock with correct dependencies * Correct load order of will_paginate to ensure it is loaded into Elasticsearch model * Fix duplicate metadata methods on AntiVirusAnalyzer after merging shared-web code into main applciation * Fix Gemfile.lock incomaptibility with bundler version * Move assets and linting configs to main application * Fix liniting errors * Fix yarn install not working * Fix static analysis task * Remove shared-web in favour of UKGovernmentBEIS/govuk-design-system-rails gem * Fix brakeman security warning * Tag govuk-design-system-rails * No need to specify linter config files * Provide meaningful error message when domains aren't set (#1375) * Bugfix: this contraint should match the SUBMIT_HOST (#1387) Fixes a bug accidentally introduced by #1375. * Run the static analysis outside of Docker. (#1390) Docker isn’t required for the static analysis checks, and running them directly is a lot faster. * Make the service runnable without Docker. (#1382) * Add `dotenv-rails` so that we can pass in environment variables to the service, without having to use Docker. Also add `pry` for debugging * Reorder gems * Update sprocket to resolve CVE-2018-3760 * Update sprockets to 3.7.2 to resolve CVE-2018-3760 * Explicitly set versions for pry and dotenv-ruby * Remove stray PSD file. (#1393) * Remove Visual Studio IDE config (#1394) * Review applications for easier testing * Update pH question for components (#1388) There are now four possible answers to the pH question, rather than a simple binary yes/no. * Fix some legacy migrations (#1396) For some reason, these called `safety_assured` or `create_table` outside of a `change` block, which doesn't work. * Frame formulation ingredients (#1397) * Redirect to the upload formulation page after declaring a component has poisonous ingredients * Fix Rubocop complaint * Use URL helpers to match paths in tests * Change page title * Allow chromedriver path to be explicitly set (#1401)
Merged
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've completely removed
shared-web:shared-webinto the main application