This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
BrandIcon: Update to latest document icons #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 9, 2018 09:39
…, which now have different formats
Jahnp
approved these changes
Jan 9, 2018
|
|
||
| .ms-BrandIcon--onepkg.ms-BrandIcon--icon16 { | ||
| background-image: url(https://spoprod-a.akamaihd.net/files/fabric/assets/item-types/16/one.png); |
There was a problem hiding this comment.
nit: the protocol/domain part of the URL could be pulled into something like a baseUrl variable to minimize repetition.
There was a problem hiding this comment.
I'll leave it as is, since there shouldn't be any changes needed here before we remove it entirely.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1087 and partially addresses #1088 by updating the
ms-BrandIconcomponent to support the latest set of document icons. You can view the previous, updated, and new icons in this CodePen.Deprecated icons
The
onepkgandxlsdocument icons do not exist in the new set. These have been temporarily mapped to theoneandxlsicons to match the mappings in Fabric React. These classes will be removed in a future release.New icons
24 new product icons have been added: